Enhance sync-webkit-git.py to support more actions.

Enhance sync-webkit-git.py to support more actions.

-r/--revision: desired revision. Use DEPS if not given.
-b/--branch: branch where to create gclient. Use origin/master if not given.
-t/--tarball: Use tarball (http://src.chromium.org/svn/releases/) DEPS instead of src/DEPS.

BUG=none
TEST=
     ./tools/sync-webkit-git.py -r 97678
     ./tools/sync-webkit-git.py -t 16.0.912.41 -b origin/svn_912

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112481

[halton, 2011-12-01 08:02:40]

Please review this patch, it enhances sync-webkit-git.py to do more things.
 * By default it will create gclient based on src/DEPS.
 * If -r/--revision used, the gclient sync to the desired revision
 * If -b/--branch used, gclient will based on given branch instead of
origin/master
 * If -t/--tarball is used, will create gclient based on DEPS from tarball on
http://src.chromium.org/svn/releases/.

[piman, 2011-12-01 08:28:46]

It looks like a good contribution. I did an initial review, mostly for style,
but I'm not really familiar with the code. I added tony who has reviewed some of
the code, maybe he would be more comfortable.

Also, it doesn't look like you signed the CLA, which is necessary as indicated
here:
http://www.chromium.org/developers/contributing-code#TOC-Get-your-code-ready
We'll need you to do this before we can accept your contribution.

http://codereview.chromium.org/8769001/diff/1/tools/sync-webkit-git.py
File tools/sync-webkit-git.py (left):

http://codereview.chromium.org/8769001/diff/1/tools/sync-webkit-git.py#oldcode40
tools/sync-webkit-git.py:40: 
I believe style says 2 lines between top-level functions.

http://codereview.chromium.org/8769001/diff/1/tools/sync-webkit-git.py
File tools/sync-webkit-git.py (right):

http://codereview.chromium.org/8769001/diff/1/tools/sync-webkit-git.py#newcode22
tools/sync-webkit-git.py:22: import re
re is already imported above

http://codereview.chromium.org/8769001/diff/1/tools/sync-webkit-git.py#newcode93
tools/sync-webkit-git.py:93: else:
how about:

if not branch_name:
  branch_name = 'origin/master'

cmd = ['git', 'log', '--no-color', '--first-parent', '--pretty=medium',
branch_name]

[piman, 2011-12-01 08:29:16]

+tony for real

[halton, 2011-12-01 08:50:02]

piman, All the three suggestions are accepted. Should I rework a new patch and
attach here?

I've sign the CLA. Since I've never commit code, should I add my name in
AUTHORS?

http://codereview.chromium.org/8769001/diff/1/tools/sync-webkit-git.py
File tools/sync-webkit-git.py (left):

http://codereview.chromium.org/8769001/diff/1/tools/sync-webkit-git.py#oldcode40
tools/sync-webkit-git.py:40: 
On 2011/12/01 08:28:46, piman wrote:
> I believe style says 2 lines between top-level functions.

Done.

http://codereview.chromium.org/8769001/diff/1/tools/sync-webkit-git.py
File tools/sync-webkit-git.py (right):

http://codereview.chromium.org/8769001/diff/1/tools/sync-webkit-git.py#newcode22
tools/sync-webkit-git.py:22: import re
On 2011/12/01 08:28:46, piman wrote:
> re is already imported above

Done.

http://codereview.chromium.org/8769001/diff/1/tools/sync-webkit-git.py#newcode93
tools/sync-webkit-git.py:93: else:
On 2011/12/01 08:28:46, piman wrote:
> how about:
> 
> if not branch_name:
>   branch_name = 'origin/master'
> 
> cmd = ['git', 'log', '--no-color', '--first-parent', '--pretty=medium',
> branch_name]

Done.

[halton, 2011-12-01 09:14:39]

The updated patch Set #2 is uploaded. Mainly changes:
1. Remove dup import re (piman's comment)
2. Two lines between top-level functions (pimans' comment)
3. Minor change to the git cmd in FindSVNRev (pimans' comment)
4. Add me in AUTHORS

[tony, 2011-12-01 17:38:41]

LGTM, just a minor nit.  I'll update it and land it for you.

http://codereview.chromium.org/8769001/diff/4002/tools/sync-webkit-git.py
File tools/sync-webkit-git.py (right):

http://codereview.chromium.org/8769001/diff/4002/tools/sync-webkit-git.py#new...
tools/sync-webkit-git.py:76: m = re.search('(?<=Source@)\w+', s)
Nit: Can we make this match WebKit/Source?  That might be a bit more future
proof.

[tony, 2011-12-01 17:49:04]

On 2011/12/01 17:38:41, tony wrote:
> LGTM, just a minor nit.  I'll update it and land it for you.
> 
> http://codereview.chromium.org/8769001/diff/4002/tools/sync-webkit-git.py
> File tools/sync-webkit-git.py (right):
> 
>
http://codereview.chromium.org/8769001/diff/4002/tools/sync-webkit-git.py#new...
> tools/sync-webkit-git.py:76: m = re.search('(?<=Source@)\w+', s)
> Nit: Can we make this match WebKit/Source?  That might be a bit more future
> proof.

Actually, that doesn't work because the paths are more like:
 'src/third_party/WebKit/Source':
      Var("webkit_trunk")[:-6] + '/branches/chromium/912/Source@99885',

I guess we'll just use /Source for now, although it seems a bit fragile.

[tony, 2011-12-01 17:50:46]

http://src.chromium.org/viewvc/chrome?view=rev&revision=112481

Thanks!