Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Issue 8764022: WebSocket Pepper API: use net::IsPortAllowedByDefault() to validate port (Closed)

Created:
9 years ago by Takashi Toyoshima
Modified:
9 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., Yuta Kitamura
Visibility:
Public.

Description

Enable port validation because net::IsPortAllowedByDefault() was exported now BUG=87310 TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_InvalidConnect'; git try -b win_shared Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112637

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase again #

Total comments: 2

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M ppapi/tests/test_websocket.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_websocket_impl.cc View 1 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Takashi Toyoshima
This change is originally included in http://codereview.chromium.org/8558017/. At that time, net::IsPortAllowedByDefault() was not exported out ...
9 years ago (2011-12-01 08:11:56 UTC) #1
dmichael (off chromium)
lgtm http://codereview.chromium.org/8764022/diff/3003/webkit/plugins/ppapi/ppb_websocket_impl.cc File webkit/plugins/ppapi/ppb_websocket_impl.cc (right): http://codereview.chromium.org/8764022/diff/3003/webkit/plugins/ppapi/ppb_websocket_impl.cc#newcode48 webkit/plugins/ppapi/ppb_websocket_impl.cc:48: Why did you move the namespace? It would ...
9 years ago (2011-12-01 16:46:08 UTC) #2
Takashi Toyoshima
Thank you for review. http://codereview.chromium.org/8764022/diff/3003/webkit/plugins/ppapi/ppb_websocket_impl.cc File webkit/plugins/ppapi/ppb_websocket_impl.cc (right): http://codereview.chromium.org/8764022/diff/3003/webkit/plugins/ppapi/ppb_websocket_impl.cc#newcode48 webkit/plugins/ppapi/ppb_websocket_impl.cc:48: Yuta suggest me this change ...
9 years ago (2011-12-02 02:20:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8764022/7001
9 years ago (2011-12-02 04:28:23 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-02 04:28:25 UTC) #5
Presubmit check for 8764022-7001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: webkit/plugins/ppapi/ppb_websocket_impl.cc

Powered by Google App Engine
This is Rietveld 408576698