Issue 8764021: Make TaskManager not use ChildProcessInfo. After this change, I will make BrowserChildProcessHost...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8764021: Make TaskManager not use ChildProcessInfo. After this change, I will make BrowserChildProcessHost... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, yoshiki+watch_chromium.org, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make TaskManager not use ChildProcessInfo. After this change, I will make BrowserChildProcessHost not derive from ChildProcessInfo, and just remove that struct completely. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112500

Patch Set 1 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -79 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.h	View	5 chunks	+33 lines, -22 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.cc	View	12 chunks	+51 lines, -43 lines	0 comments	Download
M	content/common/child_process_info.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

btw regarding removing the plugin version, I spoke with Carlos who added it and he's ...

9 years ago (2011-12-01 18:51:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/8764021/8005

9 years ago (2011-12-01 18:59:55 UTC) #3

commit-bot: I haz the power

9 years ago (2011-12-01 19:05:32 UTC) #4

Try job failure for 8764021-8005 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages