Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 8764013: remove ntp.NTPTest.testRecentlyClosedShowsUniqueItems pyauto test (Closed)

Created:
9 years ago by Evan Stade
Modified:
9 years ago
Reviewers:
sky, Nirnimesh
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

remove ntp.NTPTest.testRecentlyClosedShowsUniqueItems pyauto test we decided to show "duplicate" items in the recently closed menu because they may not actually be duplicates. For example, they may have different history even if the url and title for the tab is the same. BUG=105760 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112396

Patch Set 1 #

Patch Set 2 : also delete suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/functional/ntp.py View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
9 years ago (2011-12-01 01:35:16 UTC) #1
Nirnimesh
LGTM
9 years ago (2011-12-01 01:37:27 UTC) #2
sky
LGTM
9 years ago (2011-12-01 01:50:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8764013/2001
9 years ago (2011-12-01 01:51:21 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-01 04:29:38 UTC) #5
Change committed as 112396

Powered by Google App Engine
This is Rietveld 408576698