Set empty shared secret for Me2Me hosts.

Set empty shared secret for Me2Me hosts.

BUG=105214, 105995
TEST=Me2Me works


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112577

[Lambros, 2011-12-01 01:22:24]

Will create a bug for this when crbug.com is working again :)

[Sergey Ulanov, 2011-12-01 01:34:01]

LGTM
No need to create a separate bug, we already have 105214 for authentication
work.

http://codereview.chromium.org/8764012/diff/1/remoting/host/remoting_me2me_ho...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/8764012/diff/1/remoting/host/remoting_me2me_ho...
remoting/host/remoting_me2me_host.cc:111: // AuthenticatorFactory.
please reference crbug.com/105214 here.

http://codereview.chromium.org/8764012/diff/1/remoting/host/remoting_me2me_ho...
remoting/host/remoting_me2me_host.cc:114: std::string()));
"" - is more readable.

[Lambros, 2011-12-01 20:48:27]

PTAL, this version caches the shared key and sets it when session manager gets
created.

[Sergey Ulanov, 2011-12-01 21:10:12]

lgtm

http://codereview.chromium.org/8764012/diff/5001/remoting/host/chromoting_hos...
File remoting/host/chromoting_host.cc (right):

http://codereview.chromium.org/8764012/diff/5001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:287: if (have_shared_secret_) {
nit: I don't think we need this flag. !shared_secret_.empty() should be enough
here. Feel free to keep it if you disagree.

[Lambros, 2011-12-01 21:29:21]

http://codereview.chromium.org/8764012/diff/5001/remoting/host/chromoting_hos...
File remoting/host/chromoting_host.cc (right):

http://codereview.chromium.org/8764012/diff/5001/remoting/host/chromoting_hos...
remoting/host/chromoting_host.cc:287: if (have_shared_secret_) {
On 2011/12/01 21:10:13, sergeyu wrote:
> nit: I don't think we need this flag. !shared_secret_.empty() should be enough
> here. Feel free to keep it if you disagree.
!shared_secret_.empty() wouldn't work.  remoting_me2me_host calls
SetSharedSecret(""), which means the if{} body wouldn't execute :)

[commit-bot: I haz the power, 2011-12-01 22:08:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/8764012/5001

[commit-bot: I haz the power, 2011-12-01 22:14:55]

Try job failure for 8764012-5001 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-12-01 22:31:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/8764012/5004

[commit-bot: I haz the power, 2011-12-01 23:51:02]

Change committed as 112577