Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 8764008: Remove import ONC option from internet settings (to be moved to net-internals). (Closed)

Created:
9 years ago by achuithb
Modified:
9 years ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Remove import ONC option from internet settings (to be moved to net-internals). BUG=chromium-os:23472 TEST=Go to chrome://settings/internet, should not see import network settings option. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112509

Patch Set 1 #

Patch Set 2 : remove localized strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M chrome/browser/resources/options/chromeos/internet_options.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_options.js View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_options_page.css View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 3 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
achuithb
Please review. Thanks!
9 years ago (2011-12-01 00:27:13 UTC) #1
Charlie Lee
lgtm
9 years ago (2011-12-01 01:13:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/8764008/4001
9 years ago (2011-12-01 06:17:20 UTC) #3
commit-bot: I haz the power
Presubmit check for 8764008-4001 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-01 06:17:23 UTC) #4
achuithb
Need owner approval please.
9 years ago (2011-12-01 09:11:30 UTC) #5
James Hawkins
LGTM
9 years ago (2011-12-01 17:08:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/8764008/4001
9 years ago (2011-12-01 18:38:58 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-01 20:07:55 UTC) #8
Change committed as 112509

Powered by Google App Engine
This is Rietveld 408576698