Adding Youtube dropped frames performance measurement for different types of videos

functional/perf.py

Index: functional/perf.py
===================================================================
--- functional/perf.py	(revision 112101)
+++ functional/perf.py	(working copy)
@@ -605,9 +605,9 @@
     """Returns true if video loaded bytes information is available."""
     return self.GetVideoLoadedBytes() > 0
 
-  def StartVideoForPerformance(self):
+  def StartVideoForPerformance(self, video_id='zuzaxlddWbk'):
     """Start the test video with all required buffering."""
-    self.PlayVideoAndAssert()
+    self.PlayVideoAndAssert(video_id)
     self.ExecuteJavascript("""
         ytplayer.setPlaybackQuality('hd720');
         window.domAutomationController.send('');
@@ -631,19 +631,29 @@
     time.sleep(10)
 
   def testYoutubeDroppedFrames(self):
-    """Measures the Youtube video dropped frames/second. Runs for 60 secs."""
-    self.StartVideoForPerformance()
-    init_dropped_frames = self.GetVideoDroppedFrames()
-    total_dropped_frames = 0
-    dropped_fps = []
-    for _ in xrange(60):
-      frames = self.GetVideoDroppedFrames() - init_dropped_frames
-      current_dropped_frames = frames - total_dropped_frames 
-      dropped_fps.append(current_dropped_frames)
-      total_dropped_frames = frames
-      # Play the video for some time
-      time.sleep(1)
-    self._PrintSummaryResults('YoutubeDroppedFrames', dropped_fps, 'frames')
+    """Measures the Youtube video dropped frames/second. Runs for 60 secs.
+       
+    This test measures Youtube video dropped frames for three different types
+    of videos like slow, normal and fast motion.
+    """
+    youtube_video = {'Slow':'VT1-sitWRtY',
+                     'Normal':'2tqK_3mKQUw',
+                     'Fast':'8ETDE0VGJY4',

[dennis_jeffrey, 2011/12/01 02:44:56]

add a space right after the ':' in each of the above 3 lines.

[rohitbm, 2011/12/03 02:20:58]

Done.

+                    }
+    for video_type in youtube_video: 
+      self.StartVideoForPerformance(youtube_video[video_type])
+      init_dropped_frames = self.GetVideoDroppedFrames()
+      total_dropped_frames = 0
+      dropped_fps = []
+      for _ in xrange(60):
+        frames = self.GetVideoDroppedFrames() - init_dropped_frames
+        current_dropped_frames = frames - total_dropped_frames 
+        dropped_fps.append(current_dropped_frames)
+        total_dropped_frames = frames
+        # Play the video for some time
+        time.sleep(1)
+      graph_description = 'YoutubeDroppedFrames' + '_' + video_type

[dennis_jeffrey, 2011/12/01 02:44:56]

I recommend removing the '_' character that's being appended here.  It's not
necessary, and we should try to keep these descriptions as short as possible
since there's a 30-character limit imposed by the autotest database.

[rohitbm, 2011/12/03 02:20:58]

Done.

+      self._PrintSummaryResults(graph_description, dropped_fps, 'frames')

[dennis_jeffrey, 2011/12/01 02:44:56]

Note that this change gets rid of the old perf key named
"frames_YoutubeDroppedFrames".  So once this change lands, no more results will
show up in the existing perf graph for Youtube dropped frames.  Once you enable
the graphs for the 3 new perf keys here, we should remove the old graph.

[ilja, 2011/12/01 04:13:06]

If we already are renaming I would like all Flash tests to have the word Flash
in them. That would make it easier to find them on the perf pages and it would
distinguish between html5 tests that are surely be coming one day.

[dennis_jeffrey, 2011/12/01 18:15:33]

I'd like to create a new perf report on the autotest dashboard for only these
pyauto-based perf tests, and perhaps organize the graphs by the name of the
class containing the tests.  For example, there's a "FlashTest" class here that
contains the 3 flash tests we currently have (one of which -- the one for the
ScimarkGui benchmark -- doesn't have "flash" in the test name or the perf key). 
Organizing the graphs by test class name would ensure that ScimarkGui is grouped
with the other flash tests, even if it doesn't have "flash" in the perf key. 
Would that work for you?

I could add "flash" to the ScimarkGui test name and perf keys,  but doing so
would remove 5 characters from the description of some of the perf values (as
they appear in the graphs), due to the 30-character limit imposed by the
autotest DB.

[rohitbm, 2011/12/03 02:20:58]

Sure, I will remove the old graphs before submitting this change.

On 2011/12/01 02:44:56, dennis_jeffrey wrote:

[dennis_jeffrey, 2011/12/05 18:09:24]

I recommend waiting until we enable the new graphs, then remove the old graph
after that.  That way, we don't have a period of time when there are no Youtube
dropped frames graphs showing up on the dashboard.

On 2011/12/03 02:20:58, rohitbm wrote:

 
   def testYoutubeCPU(self):
     """Measures the Youtube video CPU usage. Runs for 60 seconds.