chrome: chromeos: dbus: simplify ProxyResolutionServiceProvider unittest

chrome/browser/chromeos/dbus/proxy_resolution_service_provider_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This test is relatively complicated. Here's the summary of what it does:
 //
 // - Set up mock D-Bus related objects to mock out D-Bus calls.
 // - Set up a mock proxy resolver to mock out the proxy resolution.
 // - Create ProxyResolutionServiceProvider by injecting the mocks
 // - Start the service provider.
@@ skipping 244 matching lines @@
     // dbus_message_new_method_return() won't emit a warning.
     method_call->SetSerial(1);
     // Run the callback captured in MockExportMethod(). In addition to returning
     // a response that the caller will ignore, this will send a signal, which
     // will be received by |on_signal_callback_|.
     resolve_network_proxy_.Run(
         method_call,
         base::Bind(&ProxyResolutionServiceProviderTest::OnResponse,
                    base::Unretained(this)));
     // Wait for a response.
-    while (!response_received_) {
+    if (!response_received_) {

[Paweł Hajdan Jr., 2011/12/01 09:24:48]

nit: Remove the braces too, {}.

[Vince Laviano, 2011/12/01 21:53:30]

Done.

       message_loop_.Run();
     }
     // Return response.
     return response_.release();
   }
 
   // Receives a response and makes it available to MockCallMethodAndBlock().
   void OnResponse(dbus::Response* response) {
     response_.reset(response);
     response_received_ = true;
@@ skipping 47 matching lines @@
   ASSERT_TRUE(response.get());
   dbus::MessageReader reader(response.get());
   ASSERT_FALSE(reader.HasMoreData());
 
   // Confirm that the signal is received successfully.
   // The contents of the signal are checked in OnSignalReceived().
   ASSERT_TRUE(signal_received_successfully_);
 }
 
 }  // namespace chromeos