Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: ui/views/controls/label.cc

Issue 8764005: views::Label should paint borders in the overridden OnPaint() method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/label.cc
diff --git a/ui/views/controls/label.cc b/ui/views/controls/label.cc
index aadac0e2a90d13d7d11104f851346b490ed59cb7..38ebf8a082e2594266b9fca9d107018c15f033b0 100644
--- a/ui/views/controls/label.cc
+++ b/ui/views/controls/label.cc
@@ -307,6 +307,10 @@ void Label::OnBoundsChanged(const gfx::Rect& previous_bounds) {
void Label::OnPaint(gfx::Canvas* canvas) {
OnPaintBackground(canvas);
+ // We skip painting the focus border because it is being handled seperately by
+ // some subclasses of Label. We do not want View's focus border painting to
+ // interfere with that.
+ OnPaintBorder(canvas);
string16 paint_text;
gfx::Rect text_bounds;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698