ppapi/tests/test_var.cc - Issue 8764004: Add DEPS include rules so we don't accidentally use base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/tests/test_var.cc

Issue 8764004: Add DEPS include rules so we don't accidentally use base (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move OS-specific macros to ppapi/tests/test_utils.h Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/tests/test_var.cc

diff --git a/ppapi/tests/test_var.cc b/ppapi/tests/test_var.cc

index 6357737bb06e58831fc53d2b7e02a6b8e52d09c7..ff899a0fb58a488225f8bbd05f7aef3fe8972107 100644

--- a/ppapi/tests/test_var.cc

+++ b/ppapi/tests/test_var.cc

@@ -8,7 +8,6 @@

#include <limits>

-#include "base/basictypes.h"

#include "ppapi/c/dev/ppb_testing_dev.h"

#include "ppapi/c/pp_var.h"

#include "ppapi/c/ppb_var.h"

@@ -46,7 +45,7 @@ std::string TestVar::TestBasicString() {

instance_->pp_instance());

{

const char kStr[] = "Hello";

- const uint32_t kStrLen(arraysize(kStr) - 1);

+ const uint32_t kStrLen(sizeof(kStr) - 1);

PP_Var str = var_interface_->VarFromUtf8(pp::Module::Get()->pp_module(),

kStr, kStrLen);

ASSERT_EQ(PP_VARTYPE_STRING, str.type);