Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: webkit/media/webmediaplayer_proxy.cc

Issue 8764002: Finish the base::Bind migration for webkit/media. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/webmediaplayer_proxy.cc
diff --git a/webkit/media/webmediaplayer_proxy.cc b/webkit/media/webmediaplayer_proxy.cc
index 6d4222c9aa7e647193d243b557a3495048f56fb4..f46b5071458dc3207489b74ebd0abd5fa0706be7 100644
--- a/webkit/media/webmediaplayer_proxy.cc
+++ b/webkit/media/webmediaplayer_proxy.cc
@@ -40,8 +40,9 @@ void WebMediaPlayerProxy::Repaint() {
if (outstanding_repaints_ < kMaxOutstandingRepaints) {
++outstanding_repaints_;
- render_loop_->PostTask(FROM_HERE,
- NewRunnableMethod(this, &WebMediaPlayerProxy::RepaintTask));
+ render_loop_->PostTask(
+ FROM_HERE,
scherkus (not reviewing) 2011/12/01 17:42:18 nit: we seemed to have settled on having: message
Ami GONE FROM CHROMIUM 2011/12/01 18:11:26 Dunno about "settled on" but that's a violation of
+ base::Bind(&WebMediaPlayerProxy::RepaintTask, this));
}
}
@@ -99,29 +100,29 @@ void WebMediaPlayerProxy::Detach() {
void WebMediaPlayerProxy::PipelineInitializationCallback(
PipelineStatus status) {
- render_loop_->PostTask(FROM_HERE, NewRunnableMethod(
- this, &WebMediaPlayerProxy::PipelineInitializationTask, status));
+ render_loop_->PostTask(FROM_HERE, base::Bind(
+ &WebMediaPlayerProxy::PipelineInitializationTask, this, status));
}
void WebMediaPlayerProxy::PipelineSeekCallback(PipelineStatus status) {
- render_loop_->PostTask(FROM_HERE, NewRunnableMethod(
- this, &WebMediaPlayerProxy::PipelineSeekTask, status));
+ render_loop_->PostTask(FROM_HERE, base::Bind(
+ &WebMediaPlayerProxy::PipelineSeekTask, this, status));
}
void WebMediaPlayerProxy::PipelineEndedCallback(PipelineStatus status) {
- render_loop_->PostTask(FROM_HERE, NewRunnableMethod(
- this, &WebMediaPlayerProxy::PipelineEndedTask, status));
+ render_loop_->PostTask(FROM_HERE, base::Bind(
+ &WebMediaPlayerProxy::PipelineEndedTask, this, status));
}
void WebMediaPlayerProxy::PipelineErrorCallback(PipelineStatus error) {
DCHECK_NE(error, media::PIPELINE_OK);
- render_loop_->PostTask(FROM_HERE, NewRunnableMethod(
- this, &WebMediaPlayerProxy::PipelineErrorTask, error));
+ render_loop_->PostTask(FROM_HERE, base::Bind(
+ &WebMediaPlayerProxy::PipelineErrorTask, this, error));
}
void WebMediaPlayerProxy::NetworkEventCallback(NetworkEvent type) {
- render_loop_->PostTask(FROM_HERE, NewRunnableMethod(
- this, &WebMediaPlayerProxy::NetworkEventTask, type));
+ render_loop_->PostTask(FROM_HERE, base::Bind(
+ &WebMediaPlayerProxy::NetworkEventTask, this, type));
}
void WebMediaPlayerProxy::AddDataSource(WebDataSource* data_source) {
@@ -184,14 +185,14 @@ void WebMediaPlayerProxy::PutCurrentFrame(
}
void WebMediaPlayerProxy::DemuxerOpened(media::ChunkDemuxer* demuxer) {
- render_loop_->PostTask(FROM_HERE, NewRunnableMethod(
- this, &WebMediaPlayerProxy::DemuxerOpenedTask,
+ render_loop_->PostTask(FROM_HERE, base::Bind(
+ &WebMediaPlayerProxy::DemuxerOpenedTask, this,
scoped_refptr<media::ChunkDemuxer>(demuxer)));
}
void WebMediaPlayerProxy::DemuxerClosed() {
- render_loop_->PostTask(FROM_HERE, NewRunnableMethod(
- this, &WebMediaPlayerProxy::DemuxerClosedTask));
+ render_loop_->PostTask(FROM_HERE, base::Bind(
+ &WebMediaPlayerProxy::DemuxerClosedTask, this));
}
void WebMediaPlayerProxy::DemuxerFlush() {

Powered by Google App Engine
This is Rietveld 408576698