Finish the base::Bind migration for webkit/media.

Finish the base::Bind migration for webkit/media.

BUG=none
TEST={content,media}_unittests,test_shell_tests,trybots


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112523

[scherkus (not reviewing), 2011-12-01 17:42:18]

LGTM w/ nits & qs

http://codereview.chromium.org/8764002/diff/1/webkit/media/buffered_data_sour...
File webkit/media/buffered_data_source_unittest.cc (right):

http://codereview.chromium.org/8764002/diff/1/webkit/media/buffered_data_sour...
webkit/media/buffered_data_source_unittest.cc:28: using ::testing::NotNull;
sanity check: can we remove any more?

http://codereview.chromium.org/8764002/diff/1/webkit/media/buffered_data_sour...
webkit/media/buffered_data_source_unittest.cc:234: const base::Closure&
network_callback,
net callback -> callback
closure -> net callback

nothing actionable here but I wonder if we can think of a better naming scheme
later

http://codereview.chromium.org/8764002/diff/1/webkit/media/buffered_resource_...
File webkit/media/buffered_resource_loader_unittest.cc (left):

http://codereview.chromium.org/8764002/diff/1/webkit/media/buffered_resource_...
webkit/media/buffered_resource_loader_unittest.cc:111: NewCallback(this,
&BufferedResourceLoaderTest::StartCallback),
sanity check: are there .h files we can stop including?

http://codereview.chromium.org/8764002/diff/1/webkit/media/webmediaplayer_pro...
File webkit/media/webmediaplayer_proxy.cc (right):

http://codereview.chromium.org/8764002/diff/1/webkit/media/webmediaplayer_pro...
webkit/media/webmediaplayer_proxy.cc:44: FROM_HERE,
nit: we seemed to have settled on having:

message_loop_->PostTask(FROM_HERE,
    base::Bind(...));

[Ami GONE FROM CHROMIUM, 2011-12-01 18:11:26]

http://codereview.chromium.org/8764002/diff/1/webkit/media/buffered_data_sour...
File webkit/media/buffered_data_source_unittest.cc (right):

http://codereview.chromium.org/8764002/diff/1/webkit/media/buffered_data_sour...
webkit/media/buffered_data_source_unittest.cc:28: using ::testing::NotNull;
On 2011/12/01 17:42:18, scherkus wrote:
> sanity check: can we remove any more?

Done.

http://codereview.chromium.org/8764002/diff/1/webkit/media/buffered_data_sour...
webkit/media/buffered_data_source_unittest.cc:234: const base::Closure&
network_callback,
On 2011/12/01 17:42:18, scherkus wrote:
> net callback -> callback
> closure -> net callback
> 
> nothing actionable here but I wonder if we can think of a better naming scheme
> later

Done.

http://codereview.chromium.org/8764002/diff/1/webkit/media/buffered_resource_...
File webkit/media/buffered_resource_loader_unittest.cc (left):

http://codereview.chromium.org/8764002/diff/1/webkit/media/buffered_resource_...
webkit/media/buffered_resource_loader_unittest.cc:111: NewCallback(this,
&BufferedResourceLoaderTest::StartCallback),
On 2011/12/01 17:42:18, scherkus wrote:
> sanity check: are there .h files we can stop including?

no.

http://codereview.chromium.org/8764002/diff/1/webkit/media/webmediaplayer_pro...
File webkit/media/webmediaplayer_proxy.cc (right):

http://codereview.chromium.org/8764002/diff/1/webkit/media/webmediaplayer_pro...
webkit/media/webmediaplayer_proxy.cc:44: FROM_HERE,
On 2011/12/01 17:42:18, scherkus wrote:
> nit: we seemed to have settled on having:
> 
> message_loop_->PostTask(FROM_HERE,
>     base::Bind(...));

Dunno about "settled on" but that's a violation of the style guide.  Part of my
base::Bind migrations has been fixing these violations.
The post-migration commonest pattern is
loop->PostTask(FROM_HERE, base::Bind(
    blah blah blah
which *is* legit in the style guide.  Changed this to that.

[commit-bot: I haz the power, 2011-12-01 18:12:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/8764002/5001

[commit-bot: I haz the power, 2011-12-01 18:12:07]

Can't apply patch for file webkit/media/buffered_data_source_unittest.cc.
While running patch -p1 --forward --force;
patching file webkit/media/buffered_data_source_unittest.cc
Hunk #1 FAILED at 20.
Hunk #2 FAILED at 84.
Hunk #3 FAILED at 124.
Hunk #4 FAILED at 173.
Hunk #5 FAILED at 236.
Hunk #6 FAILED at 257.
Hunk #7 FAILED at 280.
Hunk #8 FAILED at 304.
Hunk #9 FAILED at 318.
Hunk #10 FAILED at 328.
Hunk #11 FAILED at 357.
Hunk #12 FAILED at 381.
Hunk #13 FAILED at 395.
Hunk #14 FAILED at 412.
Hunk #15 FAILED at 559.
15 out of 15 hunks FAILED -- saving rejects to file
webkit/media/buffered_data_source_unittest.cc.rej

[commit-bot: I haz the power, 2011-12-01 19:17:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/8764002/8001

[commit-bot: I haz the power, 2011-12-01 20:34:25]

Change committed as 112523