Issue 8763020: aura: Detect double clicks and set ui::EF_IS_DOUBLE_CLICK appropriately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8763020: aura: Detect double clicks and set ui::EF_IS_DOUBLE_CLICK appropriately. (Closed)

Created:
9 years ago by sadrul

Modified:
9 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, dhollowa+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Detect double clicks and set ui::EF_IS_DOUBLE_CLICK appropriately. BUG=105958 TEST=manually, double clicked title bar of a window in aura_shell. The window maximized. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112486

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -3 lines)			Patch
	M	content/browser/renderer_host/web_input_event_aurax11.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	ui/aura/event.cc	View		2 chunks	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sadrul

It's not clear what happens if I click three times really quickly: press, up, press ...

9 years ago (2011-12-01 04:35:19 UTC) #1

I think this is fine. LGTM.

Expand Messages | Collapse Messages