Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 8763017: [Mac] Move MessagePump CrAppProtocol dependency to setup. (Closed)

Created:
9 years ago by Scott Hess - ex-Googler
Modified:
9 years ago
Reviewers:
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, ajwong+watch_chromium.org, sadrul
Visibility:
Public.

Description

[Superseded by another CL.] [Mac] Move MessagePump CrAppProtocol dependency to setup. Pull the CrAppProtocol autorelease-pool handling down into MessagePumpCrApplication, which is selected at Create() if NSApp implements the right protocol. UsingCrApp() allows clients to confirm the correct setup (unfortunately, synchronizing NSApp initialization and MessagePump::Create() would be intrusive). Also push CrAppProtocol and CrAppControlProtocol implementation up into BrowserCrApplication, and reparent that class from NSApplication. With this change, the following implementations can be removed or changed: - CrDrtApplication removed from DRT. - ServiceCrApplication reparented to NSApplication. - Remove CrApplication registration from gpu, plugin, and renderer mains. - MockCrApp dependency from remoting sample code - content/common/chrome_application_mac* Those changes intentionally left to another CL to reduce bickering. BUG=102224

Patch Set 1 #

Patch Set 2 : Sync. #

Patch Set 3 : comment oops. #

Patch Set 4 : Sigh, minimal content/ change, just to see. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -29 lines) Patch
M base/message_pump_mac.h View 2 chunks +31 lines, -6 lines 0 comments Download
M base/message_pump_mac.mm View 1 4 chunks +37 lines, -8 lines 0 comments Download
M base/test/mock_chrome_application_mac.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_application_mac.h View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_application_mac.mm View 3 chunks +27 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_application_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 3 chunks +2 lines, -6 lines 0 comments Download
M content/common/chrome_application_mac.mm View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698