Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 8763014: Use a different define to decide which CRC library to use. (Closed)

Created:
9 years ago by dgarrett
Modified:
9 years ago
Reviewers:
sra1
CC:
chromium-reviews, adlr, Michael Krebs
Visibility:
Public.

Description

Use a different define to decide which CRC library to use. Change 8569018 used a #ifdef to conditionally decide which external library to use for Crc calculation. It used OS_CHROMIUMOS to tell if the build was targetted at Chromium OS. However, it broke Chromium OS builds of the full Chromium tree in some cases (heapcheck bots), and was reverted. Since I really only want to change the library when building from inside a custom ebuild in the Chromium OS build, it makes sense to use a #define custom to that ebuild. So, this change is the same as 8569018, except that is uses COURGETTE_USE_CRC_LIB instead of OS_CHROMIUMOS. BUG=8569018 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M courgette/crc.cc View 1 chunk +19 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dgarrett
9 years ago (2011-12-01 01:55:22 UTC) #1
sra1
LGTM.
9 years ago (2011-12-01 02:20:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgarrett@chromium.org/8763014/1
9 years ago (2011-12-01 20:58:20 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-01 22:59:19 UTC) #4
Change committed as 112565

Powered by Google App Engine
This is Rietveld 408576698