Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: content/renderer/media/audio_renderer_impl_unittest.cc

Issue 8763010: Replace AudioDecoder::ProduceAudioSamples/ConsumeAudioSamples with read callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/filters.h » ('j') | media/filters/audio_renderer_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_renderer_impl_unittest.cc
diff --git a/content/renderer/media/audio_renderer_impl_unittest.cc b/content/renderer/media/audio_renderer_impl_unittest.cc
index 3a653dbd6a296c120c58ac89e2a4cb40e508bc81..9c122e5dcfc4f31a4f35c3cd6614b11a422c865c 100644
--- a/content/renderer/media/audio_renderer_impl_unittest.cc
+++ b/content/renderer/media/audio_renderer_impl_unittest.cc
@@ -177,18 +177,6 @@ TEST_F(AudioRendererImplTest, SetVolume) {
WaitForIOThreadCompletion();
}
-TEST_F(AudioRendererImplTest, Stop) {
- // Execute Stop() codepath.
- // Tasks will be posted internally on the IO thread.
- renderer_->Stop(media::NewExpectedClosure());
-
- WaitForIOThreadCompletion();
-
- // It's possible that the upstream decoder replies right after being stopped.
- scoped_refptr<media::Buffer> buffer(new media::DataBuffer(kSize));
- renderer_->ConsumeAudioSamples(buffer);
scherkus (not reviewing) 2011/12/19 19:30:13 this should never happen if there wasn't a pending
-}
-
TEST_F(AudioRendererImplTest, UpdateEarliestEndTime) {
renderer_->SetPlaybackRate(1.0f);
WaitForIOThreadCompletion();
« no previous file with comments | « no previous file | media/base/filters.h » ('j') | media/filters/audio_renderer_base.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698