Clean up cloud printing aura stub code.

printing/printed_document.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/printed_document.h"
 
 #include <algorithm>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 212 matching lines @@
                                       int cookie)
     : settings_(settings),
       source_message_loop_(MessageLoop::current()),
       name_(source->RenderSourceName()),
       cookie_(cookie) {
 }
 
 PrintedDocument::Immutable::~Immutable() {
 }
 
+#if defined(OS_POSIX) && defined(USE_AURA)

[Albert Bodenhamer, 2011/12/01 01:09:05]

Shouldn't this be OS_CHROMEOS || USE_AURA?

[jennyz, 2011/12/02 14:40:18]

This function signature is only declared for OS_POSIX in printed_document.h, so
defined(OS_POSIX) is needed, are you sure you want this for OS_CHROMEOS non-aura
build? I thought  that will use gtk implementation.

[Albert Bodenhamer, 2011/12/02 17:57:17]

On chrome os there is no native printing, only cloud print, so no need to use
the GTK version.

You can do OS_POSIX || USE_AURA, but I'm afraid you'll get a symbol collision on
Linux since it needs to pull in the GTK version.  You don't want && since you'll
want this for the non-aura chromeos build.

On 2011/12/02 14:40:18, jennyz wrote:

+// This function is not used on aura linux/chromeos.
+void PrintedDocument::RenderPrintedPage(const PrintedPage& page,
+                                        PrintingContext* context) const {
+  NOTIMPLEMENTED();

[Albert Bodenhamer, 2011/12/01 00:47:23]

I don't think NOTIMPLEMENTED is correct here.  NOTIMPLEMENTED will log an error.
 Doing nothing for this function is the CORRECT thing to do.  See logging.h line
913 for a discussion of NOTIMPLEMENTED

[jennyz, 2011/12/02 14:40:18]

Done.

+}
+#endif
+
 }  // namespace printing