DescriptionIsolate ExternalProtocolHandlerTest from other tests in the TearDown method.
The issue is that these tests call LaunchUrlWithDelegate(), which sets
g_accept_requests to false unconditionally. This can cause other tests, such
as AutocompleteInput.InputType, to fail if run with different sharding or
different ordering.
The solution is to call PermitLaunchUrl() from the TearDown method, which
resets g_accept_requests to true.
R=benwells@chromium.org
BUG=105574
TEST=Run unit_tests.exe with three shards and watch the DrMemory bots
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112404
Patch Set 1 #
Messages
Total messages: 4 (0 generated)
|