Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 8763006: Isolate ExternalProtocolHandlerTest from other tests in the TearDown method. (Closed)

Created:
9 years ago by Reid Kleckner
Modified:
9 years ago
Reviewers:
benwells
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Isolate ExternalProtocolHandlerTest from other tests in the TearDown method. The issue is that these tests call LaunchUrlWithDelegate(), which sets g_accept_requests to false unconditionally. This can cause other tests, such as AutocompleteInput.InputType, to fail if run with different sharding or different ordering. The solution is to call PermitLaunchUrl() from the TearDown method, which resets g_accept_requests to true. R=benwells@chromium.org BUG=105574 TEST=Run unit_tests.exe with three shards and watch the DrMemory bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/external_protocol/external_protocol_handler_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Reid Kleckner
9 years ago (2011-11-30 23:21:39 UTC) #1
benwells
lgtm
9 years ago (2011-11-30 23:45:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/8763006/1
9 years ago (2011-12-01 03:06:08 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-01 04:38:17 UTC) #4
Change committed as 112404

Powered by Google App Engine
This is Rietveld 408576698