Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: frog/parser.dart

Issue 8763001: Fix names with '$' to not conflict with operators or internal helpers (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merged again Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/member.dart ('k') | frog/scripts/token_info.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/parser.dart
diff --git a/frog/parser.dart b/frog/parser.dart
index a1ca3292636b9eca428d8eb79f12a9ca370817f8..924118da0c9d65d28192e518f82f93d814998f30 100644
--- a/frog/parser.dart
+++ b/frog/parser.dart
@@ -1271,7 +1271,7 @@ class Parser {
if (!includeOperators) return null;
_eat(TokenKind.GET);
if (_peekIdentifier()) {
- name = 'get\$${identifier().name}';
+ name = 'get:${identifier().name}';
} else {
name = 'get';
}
@@ -1280,7 +1280,7 @@ class Parser {
if (!includeOperators) return null;
_eat(TokenKind.SET);
if (_peekIdentifier()) {
- name = 'set\$${identifier().name}';
+ name = 'set:${identifier().name}';
} else {
name = 'set';
}
@@ -1290,7 +1290,7 @@ class Parser {
_eat(TokenKind.OPERATOR);
var kind = _peek();
if (kind == TokenKind.NEGATE) {
- name = '\$negate';
+ name = ':negate';
_next();
} else {
name = TokenKind.binaryMethodName(kind);
« no previous file with comments | « frog/member.dart ('k') | frog/scripts/token_info.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698