frog/lib/natives.dart - Issue 8763001: Fix names with '$' to not conflict with operators or internal helpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/lib/natives.dart

Issue 8763001: Fix names with '$' to not conflict with operators or internal helpers (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merged again Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/lib/natives.dart

diff --git a/frog/lib/natives.dart b/frog/lib/natives.dart

index 79bfd44b37d0b3707c23d38aaa98156242a78b97..6321634a20a8d9be1af9b0a4ee30be3a95fa21fa 100644

--- a/frog/lib/natives.dart

+++ b/frog/lib/natives.dart

@@ -45,8 +45,7 @@ if (e instanceof TypeError) {

if (e.arguments[0] == 'call' || e.arguments[0] == 'apply') {

return attachStack(new ObjectNotClosureException());

} else {

- // TODO(jmesserly): can this ever happen?

- // sra: Yes, seen on '$add'.

+ // TODO(jmesserly): fix noSuchMethod on operators so we don't hit this

return attachStack(new NoSuchMethodException('', e.arguments[0], []));

}

break;

« no previous file with comments | « frog/gen.dart ('k') | frog/library.dart » ('j') | no next file with comments »