Change the test status file parser to fail if the line contains unparsed toke...

Change the test status file parser to fail if the line contains unparsed tokens.

Refactor the platform.system() tests and use macos when running on Mac.

Committed: http://code.google.com/p/v8/source/detail?r=672

[Søren Thygesen Gjesse, 2008-10-31 10:56:54]

On 2008/10/31 09:19:02, Søren Gjesse wrote:
> 

Updated CL with platform.system() cleanup.

[Kasper Lund, 2008-10-31 12:41:52]

LGTM. Comments:

http://codereview.chromium.org/8763/diff/3/5
File tools/utils.py (right):

http://codereview.chromium.org/8763/diff/3/5#newcode56
Line 56: def GuessSystem():
How about unifying this with the GuessOS in SConstruct? Maybe rename this
GuessSystem to GuessOS let it return 'win32' in the windows case and use that
from SConstruct?

http://codereview.chromium.org/8763/diff/3/5#newcode68
Line 68: 
Extra new line here?

http://codereview.chromium.org/8763/diff/3/5#newcode70
Line 70: return GuessSystem() == 'windows'
If you change GuessSystem/GuessOS to return 'win'32 you should change this too.

[Christian Plesner Hansen, 2008-10-31 12:53:47]

Lgtm

http://codereview.chromium.org/8763/diff/3/4
File tools/test.py (right):

http://codereview.chromium.org/8763/diff/3/4#newcode922
Line 922: return None
'return None' == 'return'

http://codereview.chromium.org/8763/diff/3/5
File tools/utils.py (right):

http://codereview.chromium.org/8763/diff/3/5#newcode57
Line 57: system = platform.system()
What about doing .lower() here and then removing it elsewhere?

[Søren Thygesen Gjesse, 2008-10-31 13:17:41]

http://codereview.chromium.org/8763/diff/3/4
File tools/test.py (right):

http://codereview.chromium.org/8763/diff/3/4#newcode922
Line 922: return None
On 2008/10/31 12:53:47, Christian Plesner Hansen wrote:
> 'return None' == 'return'

The test.py file uses 'return None' all over the place.

http://codereview.chromium.org/8763/diff/3/5
File tools/utils.py (right):

http://codereview.chromium.org/8763/diff/3/5#newcode56
Line 56: def GuessSystem():
On 2008/10/31 12:41:52, Kasper Lund wrote:
> How about unifying this with the GuessOS in SConstruct? Maybe rename this
> GuessSystem to GuessOS let it return 'win32' in the windows case and use that
> from SConstruct?

Done. Renamed to GuessOS and used from SConstruct. Changed 'windows' to 'win32'.
There was no mentioning of 'windows in any test/**/*.status file.

http://codereview.chromium.org/8763/diff/3/5#newcode57
Line 57: system = platform.system()
On 2008/10/31 12:53:47, Christian Plesner Hansen wrote:
> What about doing .lower() here and then removing it elsewhere?

I decided against .lower() after all.

http://codereview.chromium.org/8763/diff/3/5#newcode68
Line 68: 
On 2008/10/31 12:41:52, Kasper Lund wrote:
> Extra new line here?

Added.

http://codereview.chromium.org/8763/diff/3/5#newcode70
Line 70: return GuessSystem() == 'windows'
On 2008/10/31 12:41:52, Kasper Lund wrote:
> If you change GuessSystem/GuessOS to return 'win'32 you should change this
too.

Done.