Issue 8762017: Support painting panel in iconified mode on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8762017: Support painting panel in iconified mode on Windows. (Closed)

Created:
9 years ago by jianli

Modified:
9 years ago

Reviewers:
Dmitry Titov, prasadt

CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, prasadt

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Support painting panel in iconified mode on Windows. This is needed to support ongoing overflow panel work. BUG=none TEST=none since overflow is not enabled yet Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112529

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix trybot #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -33 lines)			Patch
M	chrome/browser/ui/panels/panel.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_frame_view.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_frame_view.cc	View	1	4 chunks	+71 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

lgtm http://codereview.chromium.org/8762017/diff/1/chrome/browser/ui/panels/panel_browser_frame_view.cc File chrome/browser/ui/panels/panel_browser_frame_view.cc (right): http://codereview.chromium.org/8762017/diff/1/chrome/browser/ui/panels/panel_browser_frame_view.cc#newcode476 chrome/browser/ui/panels/panel_browser_frame_view.cc:476: if (width() <= IconOnlyWidth()) { Seems both branches ...

9 years ago (2011-12-01 02:28:11 UTC) #2

prasadt

9 years ago (2011-12-01 04:04:46 UTC) #3

lgtm

Just some nits.

http://codereview.chromium.org/8762017/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_frame_view.cc (right):

http://codereview.chromium.org/8762017/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_frame_view.cc:482: show_close_button =
true;
This is already true.

http://codereview.chromium.org/8762017/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_frame_view.cc:489: return;
A comment why you return here?

http://codereview.chromium.org/8762017/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_frame_view.cc:829: if
(panel_browser_view_->panel()->expansion_state() == Panel::IN_OVERFLOW)
Assert is_settings_button_visible_ is false?

Expand Messages | Collapse Messages