Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 8762006: Re-enable ExtensionApiTest.UpdateWindowShowState on Windows. (Closed)

Created:
9 years ago by jennb
Modified:
9 years ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Re-enable ExtensionApiTest.UpdateWindowShowState on Windows. The fixed window size was too small for a tabbed browser window, causing the window to grow after being restored. BUG=105356 TEST=ExtensionApiTest.UpdateWindowShowState Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112816

Patch Set 1 #

Patch Set 2 : fix ifdef #

Patch Set 3 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/api_test/window_update/show_state/test.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jennb
9 years ago (2011-11-30 22:48:28 UTC) #1
jennb
Try bot result: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/6182
9 years ago (2011-12-02 01:30:19 UTC) #2
Dmitry Titov
lgtm
9 years ago (2011-12-02 01:45:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/8762006/2001
9 years ago (2011-12-02 01:51:10 UTC) #4
commit-bot: I haz the power
Try job failure for 8762006-2001 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=3199 Step "update" is always ...
9 years ago (2011-12-02 02:00:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/8762006/8001
9 years ago (2011-12-02 22:46:06 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-02 22:46:09 UTC) #7
Presubmit check for 8762006-8001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/test/data/extensions/api_test/window_update/show_state/test.js, line
66, 94 chars

Powered by Google App Engine
This is Rietveld 408576698