Issue 8762004: Cleanup: Make RenderViewHostDelegateViewHelper::CreateNewWindow() private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8762004: Cleanup: Make RenderViewHostDelegateViewHelper::CreateNewWindow() private. (Closed)

Created:
9 years ago by Lei Zhang

Modified:
9 years ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Cleanup: Make RenderViewHostDelegateViewHelper::CreateNewWindow() private. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112550

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
	M	chrome/browser/tab_contents/render_view_host_delegate_helper.h	View		5 chunks	+18 lines, -14 lines	0 comments	Download
	M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8762004/1002

9 years ago (2011-12-01 20:15:59 UTC) #3

Change committed as 112550