Isolates generic DnsClient from AsyncHostResolver.

net/base/bigendian_unittest.cc

Index: net/base/bigendian_unittest.cc
diff --git a/net/base/bigendian_unittest.cc b/net/base/bigendian_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..97065c95bc7d05d766546a93f0304e1d131b6578
--- /dev/null
+++ b/net/base/bigendian_unittest.cc
@@ -0,0 +1,98 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/base/bigendian.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+TEST(BigEndianReaderTest, ReadsValues) {
+  char data[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0xa, 0xb, 0xc };
+  char buf[2];
+  uint8 u8;
+  uint16 u16;
+  uint32 u32;
+  base::StringPiece piece;
+  BigEndianReader r(data, sizeof(data));
+
+  EXPECT_TRUE(r.Skip(2));
+  EXPECT_EQ(data + 2, r.ptr());
+  EXPECT_EQ(r.remaining(), static_cast<int>(sizeof(data)) - 2);
+  EXPECT_TRUE(r.Copy(buf, sizeof(buf)));

[mmenke, 2011/12/02 00:53:55]

I suggest adding linebreaks before each function that reads from or writes to
the BigEndianReader's ptr_ (Skip(), Copy(), U8(), etc) to increase readability,
but up to you.

[szym, 2011/12/05 23:06:28]

Done.

+  EXPECT_EQ(0x2, buf[0]);
+  EXPECT_EQ(0x3, buf[1]);
+  EXPECT_TRUE(r.U8(&u8));
+  EXPECT_EQ(0x4, u8);
+  EXPECT_TRUE(r.U16(&u16));
+  EXPECT_EQ(0x0506, u16);
+  EXPECT_TRUE(r.U32(&u32));
+  EXPECT_EQ(0x0708090au, u32);

[mmenke, 2011/12/02 00:53:55]

nit:  I suggest you capitalize all your hexadecimal characters.  "au" just looks
weird.

[szym, 2011/12/05 23:06:28]

Done.

+  base::StringPiece expected(r.ptr(), 2);
+  EXPECT_TRUE(r.Piece(&piece, 2));
+  EXPECT_EQ(2, static_cast<int>(piece.size()));
+  EXPECT_EQ(expected.data(), piece.data());
+}
+
+TEST(BigEndianReaderTest, RespectsLength) {
+  char data[4];
+  char buf[2];
+  uint8 u8;
+  uint16 u16;
+  uint32 u32;
+  base::StringPiece piece;
+  BigEndianReader r(data, sizeof(data));
+  // 4 left
+  EXPECT_FALSE(r.Skip(6));
+  EXPECT_TRUE(r.Skip(1));
+  // 3 left
+  EXPECT_FALSE(r.U32(&u32));
+  EXPECT_FALSE(r.Piece(&piece, 4));
+  EXPECT_TRUE(r.Skip(2));
+  // 1 left
+  EXPECT_FALSE(r.U16(&u16));
+  EXPECT_FALSE(r.Copy(buf, 2));
+  EXPECT_TRUE(r.Skip(1));
+  // 0 left
+  EXPECT_FALSE(r.U8(&u8));
+  EXPECT_EQ(0, r.remaining());
+}
+
+TEST(BigEndianWriterTest, WritesValues) {
+  char expected[] = { 0, 0, 2, 3, 4, 5, 6, 7, 8, 9, 0xa };
+  char data[sizeof(expected)];
+  char buf[] = { 0x2, 0x3 };
+  memset(data, 0, sizeof(data));
+  BigEndianWriter w(data, sizeof(data));
+  EXPECT_TRUE(w.Skip(2));
+  EXPECT_TRUE(w.Copy(buf, sizeof(buf)));
+  EXPECT_TRUE(w.U8(0x4));
+  EXPECT_TRUE(w.U16(0x0506));
+  EXPECT_TRUE(w.U32(0x0708090a));
+  EXPECT_EQ(0, memcmp(expected, data, sizeof(expected)));
+}
+
+TEST(BigEndianWriterTest, RespectsLength) {
+  char data[4];
+  char buf[2];
+  uint8 u8 = 0;
+  uint16 u16 = 0;
+  uint32 u32 = 0;
+  BigEndianWriter w(data, sizeof(data));
+  // 4 left
+  EXPECT_FALSE(w.Skip(6));
+  EXPECT_TRUE(w.Skip(1));
+  // 3 left
+  EXPECT_FALSE(w.U32(u32));
+  EXPECT_TRUE(w.Skip(2));
+  // 1 left
+  EXPECT_FALSE(w.U16(u16));
+  EXPECT_FALSE(w.Copy(buf, 2));
+  EXPECT_TRUE(w.Skip(1));
+  // 0 left
+  EXPECT_FALSE(w.U8(u8));
+  EXPECT_EQ(0, w.remaining());
+}
+
+}  // namespace net
+