Isolates generic DnsClient from AsyncHostResolver.

net/dns/async_host_resolver.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/async_host_resolver.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/logging.h"
+#include "base/message_loop.h"
 #include "base/rand_util.h"
 #include "base/stl_util.h"
 #include "base/values.h"
 #include "net/base/address_list.h"
 #include "net/base/dns_util.h"
 #include "net/base/net_errors.h"
+#include "net/dns/dns_protocol.h"
+#include "net/dns/dns_response.h"
+#include "net/dns/dns_session.h"
 #include "net/socket/client_socket_factory.h"
 
 namespace net {
 
 namespace {
 
 // TODO(agayev): fix this when IPv6 support is added.
 uint16 QueryTypeFromAddressFamily(AddressFamily address_family) {
-  return kDNS_A;
+  return dns_protocol::kTypeA;
 }
 
 class RequestParameters : public NetLog::EventParameters {
  public:
   RequestParameters(const HostResolver::RequestInfo& info,
                     const NetLog::Source& source)
       : info_(info), source_(source) {}
 
   virtual Value* ToValue() const {
     DictionaryValue* dict = new DictionaryValue();
@@ skipping 17 matching lines @@
 
 }  // namespace
 
 HostResolver* CreateAsyncHostResolver(size_t max_concurrent_resolves,
                                       const IPAddressNumber& dns_ip,
                                       NetLog* net_log) {
   size_t max_transactions = max_concurrent_resolves;
   if (max_transactions == 0)
     max_transactions = 20;
   size_t max_pending_requests = max_transactions * 100;
+  DnsConfig config;
+  config.nameservers.push_back(IPEndPoint(dns_ip, 53));
+  DnsSession* session = new DnsSession(
+      config,
+      ClientSocketFactory::GetDefaultFactory(),
+      base::Bind(&base::RandInt),
+      net_log);
   HostResolver* resolver = new AsyncHostResolver(
-      IPEndPoint(dns_ip, 53),
       max_transactions,
       max_pending_requests,
-      base::Bind(&base::RandInt),
       HostCache::CreateDefaultCache(),
-      NULL,
+      DnsClient::CreateClient(session),
       net_log);
   return resolver;
 }
 
 //-----------------------------------------------------------------------------
 // Every call to Resolve() results in Request object being created.  Such a
 // call may complete either synchronously or asynchronously or it may get
 // cancelled, which can be either through specific CancelRequest call or by
 // the destruction of AsyncHostResolver, which would destruct pending or
 // in-progress requests, causing them to be cancelled.  Synchronous
@@ skipping 106 matching lines @@
   BoundNetLog source_net_log_;
   BoundNetLog request_net_log_;
   const HostResolver::RequestInfo info_;
   Key key_;
   CompletionCallback callback_;
   AddressList* addresses_;
   int result_;
 };
 
 //-----------------------------------------------------------------------------
-AsyncHostResolver::AsyncHostResolver(const IPEndPoint& dns_server,
-                                     size_t max_transactions,
+AsyncHostResolver::AsyncHostResolver(size_t max_transactions,
                                      size_t max_pending_requests,
-                                     const RandIntCallback& rand_int_cb,
                                      HostCache* cache,
-                                     ClientSocketFactory* factory,
+                                     DnsClient* client,
                                      NetLog* net_log)
     : max_transactions_(max_transactions),
       max_pending_requests_(max_pending_requests),
-      dns_server_(dns_server),
-      rand_int_cb_(rand_int_cb),
       cache_(cache),
-      factory_(factory),
+      client_(client),
       net_log_(net_log) {
 }
 
 AsyncHostResolver::~AsyncHostResolver() {
   // Destroy request lists.
   for (KeyRequestListMap::iterator it = requestlist_map_.begin();
        it != requestlist_map_.end(); ++it)
     STLDeleteElements(&it->second);
 
   // Destroy transactions.
-  STLDeleteElements(&transactions_);
+  STLDeleteElements(&dns_requests_);
 
   // Destroy pending requests.
   for (size_t i = 0; i < arraysize(pending_requests_); ++i)
     STLDeleteElements(&pending_requests_[i]);
 }
 
 int AsyncHostResolver::Resolve(const RequestInfo& info,
                                AddressList* addresses,
                                const CompletionCallback& callback,
                                RequestHandle* out_req,
                                const BoundNetLog& source_net_log) {
   DCHECK(addresses);
   DCHECK_EQ(false, callback.is_null());
   scoped_ptr<Request> request(
       CreateNewRequest(info, callback, addresses, source_net_log));
 
   int rv = ERR_UNEXPECTED;
   if (!request->IsValid())
     rv = ERR_NAME_NOT_RESOLVED;
   else if (request->ResolveAsIp() || request->ServeFromCache())
     rv = request->result();
   else if (AttachToRequestList(request.get()))
     rv = ERR_IO_PENDING;
-  else if (transactions_.size() < max_transactions_)
+  else if (dns_requests_.size() < max_transactions_)
     rv = StartNewTransactionFor(request.get());
   else
     rv = Enqueue(request.get());
 
   if (rv != ERR_IO_PENDING) {
     request->OnSyncComplete(rv);
   } else {
     Request* req = request.release();
     if (out_req)
       *out_req = reinterpret_cast<RequestHandle>(req);
@@ skipping 66 matching lines @@
 }
 
 AddressFamily AsyncHostResolver::GetDefaultAddressFamily() const {
   return ADDRESS_FAMILY_IPV4;
 }
 
 HostCache* AsyncHostResolver::GetHostCache() {
   return cache_.get();
 }
 
-void AsyncHostResolver::OnTransactionComplete(
+void AsyncHostResolver::OnRequestComplete(
+    DnsClient::Request* dns_req,
     int result,
-    const DnsTransaction* transaction,
-    const IPAddressList& ip_addresses) {
-  DCHECK(std::find(transactions_.begin(), transactions_.end(), transaction)
-         != transactions_.end());
-  DCHECK(requestlist_map_.find(transaction->key()) != requestlist_map_.end());
+    const DnsResponse* response) {
+  DCHECK(std::find(dns_requests_.begin(), dns_requests_.end(), dns_req)
+         != dns_requests_.end());
 
   // If by the time requests that caused |transaction| are cancelled, we do
   // not have a port number to associate with the result, therefore, we
   // assume the most common port, otherwise we use the port number of the
   // first request.
-  RequestList& requests = requestlist_map_[transaction->key()];
+  KeyRequestListMap::iterator rit = requestlist_map_.find(
+      std::make_pair(dns_req->qname(), dns_req->qtype()));
+  DCHECK(rit != requestlist_map_.end());
+  RequestList& requests = rit->second;
   int port = requests.empty() ? 80 : requests.front()->info().port();
 
+  // Extract AddressList out of DnsResponse.
+  AddressList addrlist;

[mmenke, 2011/12/02 00:53:55]

nit:  Should be an underscore between words:  addr_list.

[szym, 2011/12/05 23:06:28]

Done.

+  if (result == OK) {
+    IPAddressList ip_addresses;
+    DnsRecordParser parser = response->Parser();
+    DnsResourceRecord record;
+    // TODO(szym): add stricter checking of names, aliases and address lengths

[mmenke, 2011/12/02 00:53:55]

Nit:  Capitalize "add", add period.

[szym, 2011/12/05 23:06:28]

Done.

+    while (parser.ParseRecord(&record)) {
+      if (record.type == dns_req->qtype() &&
+          (record.rdata.size() == kIPv4AddressSize ||
+           record.rdata.size() == kIPv6AddressSize))

[mmenke, 2011/12/02 00:53:55]

Chrome style is to use braces on if statements, when the condition or statement
block runs onto multiple lines.

[szym, 2011/12/05 23:06:28]

Done.

+        ip_addresses.push_back(IPAddressNumber(record.rdata.begin(),
+                                               record.rdata.end()));
+    }
+    if (!ip_addresses.empty())
+      addrlist = AddressList::CreateFromIPAddressList(ip_addresses, port);
+    else
+      result = ERR_DNS_MALFORMED_RESPONSE;
+  }
+
   // Run callback of every request that was depending on this transaction,
   // also notify observers.
-  AddressList addrlist;
-  if (result == OK)
-    addrlist = AddressList::CreateFromIPAddressList(ip_addresses, port);
   for (RequestList::iterator it = requests.begin(); it != requests.end();
        ++it)
     (*it)->OnAsyncComplete(result, addrlist);
 
   // It is possible that the requests that caused |transaction| to be
   // created are cancelled by the time |transaction| completes.  In that
   // case |requests| would be empty.  We are knowingly throwing away the
   // result of a DNS resolution in that case, because (a) if there are no
   // requests, we do not have info to obtain a key from, (b) DnsTransaction
   // does not have info(), adding one into it just temporarily doesn't make
   // sense, since HostCache will be replaced with RR cache soon, (c)
   // recreating info from DnsTransaction::Key adds a lot of temporary
   // code/functions (like converting back from qtype to AddressFamily.)
   // Also, we only cache positive results.  All of this will change when RR
   // cache is added.
   if (result == OK && cache_.get() && !requests.empty()) {
     Request* request = requests.front();
     HostResolver::RequestInfo info = request->info();
     HostCache::Key key(
         info.hostname(), info.address_family(), info.host_resolver_flags());
     cache_->Set(key, result, addrlist, base::TimeTicks::Now());
   }
 
   // Cleanup requests.
   STLDeleteElements(&requests);
-  requestlist_map_.erase(transaction->key());
+  requestlist_map_.erase(rit);
 
   // Cleanup transaction and start a new one if there are pending requests.
-  delete transaction;
-  transactions_.remove(transaction);
+  delete dns_req;
+  dns_requests_.remove(dns_req);
   ProcessPending();
 }
 
 AsyncHostResolver::Request* AsyncHostResolver::CreateNewRequest(
     const RequestInfo& info,
     const CompletionCallback& callback,
     AddressList* addresses,
     const BoundNetLog& source_net_log) {
   BoundNetLog request_net_log = BoundNetLog::Make(net_log_,
       NetLog::SOURCE_ASYNC_HOST_RESOLVER_REQUEST);
   return new Request(
       this, source_net_log, request_net_log, info, callback, addresses);
 }
 
 bool AsyncHostResolver::AttachToRequestList(Request* request) {
   KeyRequestListMap::iterator it = requestlist_map_.find(request->key());
   if (it == requestlist_map_.end())
     return false;
   it->second.push_back(request);
   return true;
 }
 
 int AsyncHostResolver::StartNewTransactionFor(Request* request) {
   DCHECK(requestlist_map_.find(request->key()) == requestlist_map_.end());
-  DCHECK(transactions_.size() < max_transactions_);
+  DCHECK(dns_requests_.size() < max_transactions_);
 
   request->request_net_log().AddEvent(
       NetLog::TYPE_ASYNC_HOST_RESOLVER_CREATE_DNS_TRANSACTION, NULL);
 
   requestlist_map_[request->key()].push_back(request);
-  DnsTransaction* transaction = new DnsTransaction(
-      dns_server_,
+  DnsClient::Request* dns_req = client_->CreateRequest(
       request->key().first,
       request->key().second,
-      rand_int_cb_,
-      factory_,
-      request->request_net_log(),
-      net_log_);
-  transaction->SetDelegate(this);
-  transactions_.push_back(transaction);
-  return transaction->Start();
+      base::Bind(&AsyncHostResolver::OnRequestComplete, base::Unretained(this)),
+      request->request_net_log());
+  dns_requests_.push_back(dns_req);
+  return dns_req->Start();
 }
 
 int AsyncHostResolver::Enqueue(Request* request) {
   Request* evicted_request = Insert(request);
   int rv = ERR_HOST_RESOLVER_QUEUE_TOO_LARGE;
   if (evicted_request == request)
     return rv;
   if (evicted_request != NULL) {
     evicted_request->OnAsyncComplete(rv, AddressList());
     delete evicted_request;
@@ skipping 56 matching lines @@
         it = requests.erase(it);
       } else {
         ++it;
       }
     }
   }
   StartNewTransactionFor(request);
 }
 
 }  // namespace net