Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: chrome/renderer/extensions/chrome_v8_extension.h

Issue 8761020: Only create chromeHidden object when needed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move GetChromeHidden to ChromeV8Context Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/chrome_v8_context.cc ('k') | chrome/renderer/extensions/chrome_v8_extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/chrome_v8_extension.h
diff --git a/chrome/renderer/extensions/chrome_v8_extension.h b/chrome/renderer/extensions/chrome_v8_extension.h
index a8a0578ee9ce1869703d1d077d9fbc561336913d..a779f91c6cdfe57d31a19b93d36b01538ad9b40a 100644
--- a/chrome/renderer/extensions/chrome_v8_extension.h
+++ b/chrome/renderer/extensions/chrome_v8_extension.h
@@ -25,12 +25,6 @@ class RenderView;
// This is a base class for chrome extension bindings. Common features that
// are shared by different modules go here.
-//
-// TODO(aa): Remove the extension-system specific bits of this and move to
-// renderer/, or even to renderer/bindings and use DEPS to enforce separation
-// from extension system.
-//
-// TODO(aa): Add unit testing for this class.
class ChromeV8Extension : public v8::Extension {
public:
typedef std::set<ChromeV8Extension*> InstanceSet;
@@ -48,11 +42,6 @@ class ChromeV8Extension : public v8::Extension {
ExtensionDispatcher* extension_dispatcher() { return extension_dispatcher_; }
- // Returns a hidden variable for use by the bindings in the specified context
- // that is unreachable by the page for the current context.
- static v8::Handle<v8::Value> GetChromeHidden(
- const v8::Handle<v8::Context>& context);
-
void ContextWillBeReleased(ChromeV8Context* context);
// Derived classes should call this at the end of their implementation in
« no previous file with comments | « chrome/renderer/extensions/chrome_v8_context.cc ('k') | chrome/renderer/extensions/chrome_v8_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698