Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8761018: Start the IME Daemon when adding an extension IME (Closed)

Created:
9 years ago by Zachary Kuznia
Modified:
9 years ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, nkostylev+watch_chromium.org, Erik does not do reviews, mihaip+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Start the IME Daemon when adding an extension IME Cleanup the connection member of the engine object when destructing. Properly unregister IMEs when unloading extensions. BUG=chromium-os:21357, 21514, 21355 TEST=See bugs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113284

Patch Set 1 #

Patch Set 2 : Code review #

Patch Set 3 : Code Review #

Total comments: 6

Patch Set 4 : Code review fix #

Patch Set 5 : Pre-submit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -45 lines) Patch
M chrome/browser/chromeos/input_method/ibus_engine_controller.cc View 4 chunks +51 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.cc View 6 chunks +19 lines, -16 lines 0 comments Download
M chrome/browser/extensions/extension_input_ime_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_input_ime_api.cc View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Zachary Kuznia
Yusuke, could you have a look at this CL?
9 years ago (2011-12-02 23:03:26 UTC) #1
Aaron Boodman
lgtm
9 years ago (2011-12-03 04:53:28 UTC) #2
Yusuke Sato
generally lg, but I have one question:
9 years ago (2011-12-05 03:42:04 UTC) #3
Yusuke Sato
http://codereview.chromium.org/8761018/diff/3001/chrome/browser/chromeos/input_method/ibus_engine_controller.cc File chrome/browser/chromeos/input_method/ibus_engine_controller.cc (right): http://codereview.chromium.org/8761018/diff/3001/chrome/browser/chromeos/input_method/ibus_engine_controller.cc#newcode86 chrome/browser/chromeos/input_method/ibus_engine_controller.cc:86: (*ix)->connection = NULL; Question: which function will delete the ...
9 years ago (2011-12-05 03:42:13 UTC) #4
Zachary Kuznia
http://codereview.chromium.org/8761018/diff/3001/chrome/browser/chromeos/input_method/ibus_engine_controller.cc File chrome/browser/chromeos/input_method/ibus_engine_controller.cc (right): http://codereview.chromium.org/8761018/diff/3001/chrome/browser/chromeos/input_method/ibus_engine_controller.cc#newcode86 chrome/browser/chromeos/input_method/ibus_engine_controller.cc:86: (*ix)->connection = NULL; On 2011/12/05 03:42:13, Yusuke Sato wrote: ...
9 years ago (2011-12-06 01:50:08 UTC) #5
Yusuke Sato
LGTM On 2011/12/06 01:50:08, Zachary Kuznia wrote: > http://codereview.chromium.org/8761018/diff/3001/chrome/browser/chromeos/input_method/ibus_engine_controller.cc > File chrome/browser/chromeos/input_method/ibus_engine_controller.cc (right): > > ...
9 years ago (2011-12-06 02:00:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/8761018/14001
9 years ago (2011-12-06 21:42:25 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-06 23:36:34 UTC) #8 
Change committed as 113284

Powered by Google App Engine
This is Rietveld 408576698