Shaving parallel authenticator yak to remove unnecessary dependency on this class from OAuth spec...

Shaving parallel authenticator yak to remove unnecessary dependency on this class from OAuth specific code. Moved system salt and supplemental key related methods to cryptohome and cert libraries instead.

BUG=chromium-os:23301
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112834

[zel, 2011-12-01 02:25:37]

please note that OAuth part is not utilized within the code just yet, that part
is coming in my next CL...

[Nikita (slow), 2011-12-01 14:34:12]

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/cert_library.cc (right):

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/cert_library.cc:136: return;
Perhaps add supplemental_user_key_.reset(NULL); here too?

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/cryptohome_library.cc (right):

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/cryptohome_library.cc:28: std::string
DecryptTokenWithKey(
DecryptTokenWithKey() should be moved to some common place to avoid code
duplication between CertLibrary and CryptohomeLibrary.

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:28: #include
"chrome/browser/chromeos/cros/cert_library.h"
nit: Move one line up.

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:323: StartDocsTokenRetreival();
Could this be initiated from FetchSecondaryTokens()?
So that if we'll need to add another services, they'll be added there too.

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/parallel_authenticator.cc (left):

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/parallel_authenticator.cc:36: #include
"crypto/encryptor.h"
Unused includes should be removed with this code move.

[zel, 2011-12-02 02:35:23]

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/cert_library.cc (right):

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/cert_library.cc:136: return;
On 2011/12/01 14:34:13, Nikita Kostylev wrote:
> Perhaps add supplemental_user_key_.reset(NULL); here too?

Done.

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/cryptohome_library.cc (right):

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/cryptohome_library.cc:28: std::string
DecryptTokenWithKey(
On 2011/12/01 14:34:13, Nikita Kostylev wrote:
> DecryptTokenWithKey() should be moved to some common place to avoid code
> duplication between CertLibrary and CryptohomeLibrary.

CryptohomeLibrary does not need to have this one. It's removed from there now.

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:28: #include
"chrome/browser/chromeos/cros/cert_library.h"
On 2011/12/01 14:34:13, Nikita Kostylev wrote:
> nit: Move one line up.

Done.

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:323: StartDocsTokenRetreival();
On 2011/12/01 14:34:13, Nikita Kostylev wrote:
> Could this be initiated from FetchSecondaryTokens()?
> So that if we'll need to add another services, they'll be added there too.

All docs token retrieval related changes in this class have been removed. This
will be migrated into TokenService instead.

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/parallel_authenticator.cc (left):

http://codereview.chromium.org/8761016/diff/7001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/parallel_authenticator.cc:36: #include
"crypto/encryptor.h"
On 2011/12/01 14:34:13, Nikita Kostylev wrote:
> Unused includes should be removed with this code move.

yeah and few others got removed. done.

[xiyuan, 2011-12-02 04:15:05]

lgtm

[Nikita (slow), 2011-12-02 11:38:14]

lgtm

[commit-bot: I haz the power, 2011-12-02 22:52:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/8761016/31001

[commit-bot: I haz the power, 2011-12-03 00:57:03]

Change committed as 112834