Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 8761014: Print Preview: Set source modifiable bit for scripted printing. (Closed)

Created:
9 years ago by Lei Zhang
Modified:
9 years ago
Reviewers:
dpapad
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Print Preview: Set source modifiable bit for scripted printing. BUG=105933 TEST=see bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112397

Patch Set 1 #

Patch Set 2 : remove logging statement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M chrome/browser/printing/print_preview_message_handler.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/printing/print_view_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 4 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/common/print_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
9 years ago (2011-12-01 01:17:00 UTC) #1
dpapad
LGTM
9 years ago (2011-12-01 01:52:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8761014/5002
9 years ago (2011-12-01 01:56:55 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-01 04:29:49 UTC) #4
Change committed as 112397

Powered by Google App Engine
This is Rietveld 408576698