Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 8761012: Remove the old views bubble code. (Closed)

Created:
9 years ago by msw
Modified:
9 years ago
Reviewers:
alicet1, sky
CC:
chromium-reviews, msw+watch_chromium.org, alicet1
Visibility:
Public.

Description

Remove the old views bubble code. Bubbles previously using this code now use ui/views/bubble. This code is now dead and can be removed; yay! BUG=97248, 98312, 98322, 98323 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112633

Patch Set 1 #

Patch Set 2 : Remove gypi references. #

Patch Set 3 : Sync. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -882 lines) Patch
D chrome/browser/ui/views/bubble/border_contents.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/views/bubble/border_contents.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/views/bubble/border_widget_win.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/ui/views/bubble/border_widget_win.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/ui/views/bubble/bubble.h View 1 chunk +0 lines, -269 lines 0 comments Download
D chrome/browser/ui/views/bubble/bubble.cc View 1 chunk +0 lines, -442 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Please take a look; it's been a fun ride!
9 years ago (2011-12-01 00:35:30 UTC) #1
msw
+Sky for OWNERS.
9 years ago (2011-12-01 19:23:33 UTC) #2
sky
LGTM
9 years ago (2011-12-01 20:23:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8761012/2002
9 years ago (2011-12-01 20:24:01 UTC) #4
commit-bot: I haz the power
Try job failure for 8761012-2002 (retry) (retry) on win_rel for step "update". It's a second ...
9 years ago (2011-12-01 22:36:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8761012/9001
9 years ago (2011-12-02 02:58:47 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-02 04:17:00 UTC) #7
Change committed as 112633

Powered by Google App Engine
This is Rietveld 408576698