Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 8760024: Cross-process postMessage (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index d238d28761ca81c6d7af2a45a7efb90e52383361..2c55ae6bef1434182088c26b0530d6d9a2667e9e 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -733,17 +733,9 @@ bool ChromeContentRendererClient::CrossesExtensionExtents(
const Extension* old_url_extension = GetNonBookmarkAppExtension(extensions,
old_url);
- // TODO(creis): Temporary workaround for crbug.com/59285: Only return true if
- // we would enter an extension app's extent from a non-app, or if we leave an
- // extension with no web extent. We avoid swapping processes to exit a hosted
- // app for now, since we do not yet support postMessage calls from outside the
- // app back into it (e.g., as in Facebook OAuth 2.0).
- bool old_url_is_hosted_app = old_url_extension &&
- !old_url_extension->web_extent().is_empty();
- if (old_url_is_hosted_app)
- return false;
-
+ // TODO(supersat): Make sure this change is correct
Charlie Reis 2011/12/01 23:13:02 Yes, this is what I intended.
supersat 2011/12/09 23:08:20 Done.
return old_url_extension != new_url_extension;
+
}
void ChromeContentRendererClient::OnPurgeMemory() {

Powered by Google App Engine
This is Rietveld 408576698