Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: chrome/browser/extensions/app_process_apitest.cc

Issue 8760024: Cross-process postMessage (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | chrome/browser/ui/browser_navigator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/app_process_apitest.cc
diff --git a/chrome/browser/extensions/app_process_apitest.cc b/chrome/browser/extensions/app_process_apitest.cc
index 0789c6ef7b9be3d021cbb5e68db5e82401b8a745..e7e659a12965b3663b2201c3abd4e01dc2f1389f 100644
--- a/chrome/browser/extensions/app_process_apitest.cc
+++ b/chrome/browser/extensions/app_process_apitest.cc
@@ -149,10 +149,7 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, AppProcess) {
WindowOpenHelper(browser(), host,
base_url.Resolve("path2/empty.html"), true);
LOG(INFO) << "WindowOpenHelper 2.";
- // TODO(creis): This should open in a new process (i.e., false for the last
- // argument), but we temporarily avoid swapping processes away from an app
- // until we're able to support cross-process postMessage calls.
- // See crbug.com/59285.
+ // This should open in a new process (i.e., false for the last argument).
WindowOpenHelper(browser(), host,
base_url.Resolve("path3/empty.html"), true);
LOG(INFO) << "WindowOpenHelper 3.";
@@ -165,10 +162,7 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, AppProcess) {
LOG(INFO) << "NavigateTabHelper 1.";
NavigateTabHelper(browser()->GetTabContentsAt(3), app_url);
LOG(INFO) << "NavigateTabHelper 2.";
- // TODO(creis): This should swap out of the app's process (i.e., EXPECT_NE),
- // but we temporarily avoid swapping away from an app in case the window
- // tries to send a postMessage to the app. See crbug.com/59285.
- EXPECT_EQ(host->process(),
+ EXPECT_NE(host->process(),
browser()->GetTabContentsAt(2)->render_view_host()->process());
EXPECT_EQ(host->process(),
browser()->GetTabContentsAt(3)->render_view_host()->process());
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | chrome/browser/ui/browser_navigator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698