Cross-process postMessage

content/browser/browsing_instance_frame_id.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_WORKER_HOST_BROWSING_INSTANCE_FRAME_ID_H_
+#define CONTENT_BROWSER_WORKER_HOST_BROWSING_INSTANCE_FRAME_ID_H_

[Charlie Reis, 2011/12/01 23:13:02]

Nit: remove WORKER_HOST

[supersat, 2011/12/09 23:08:20]

Done.

+
+#include "base/basictypes.h"
+#include "base/hash_tables.h"
+#include <list>
+
+namespace content {
+class FrameMapper;
+
+class BrowsingInstanceFrame {

[Charlie Reis, 2011/12/01 23:13:02]

I don't understand this name.  A BrowsingInstance is a collection of tabs that
can script each other, but this class seems to represent the browser's notion of
a frame (either a tab or a sub-frame).

Also, should this keep track of all the WebKitFrameIdTuples for this frame? 
We'll need to tell them all to go away this frame closes.

[supersat, 2011/12/09 23:08:20]

I agree the name could improve. Any suggestions? This class represents a
user-perceived frame whose IDs are unique per browsing instance.
Yes. Added.

[Charlie Reis, 2011/12/12 22:20:36]

I see that you're trying to get the scope of the ID in the class name, but I'm
not sure we need that.  Maybe something like ContentFrame?

[supersat, 2011/12/15 19:30:49]

SGTM. Renamed.

+  friend class FrameMapper;
+
+  public:
+    struct WebKitFrameIdTuple {
+      WebKitFrameIdTuple(int process_host_id, int64 frame_id);
+      bool operator==(const WebKitFrameIdTuple& other) const;
+
+      int process_host_id;
+      int64 frame_id;
+    };
+
+    BrowsingInstanceFrame(int64 id, bool is_top_level);
+    virtual ~BrowsingInstanceFrame();
+
+    int64 id() { return id_; }
+
+    const WebKitFrameIdTuple current_webkit_frame() const {
+      return current_webkit_frame_;
+    }
+
+    int current_process_host_id() const {
+      return current_webkit_frame_.process_host_id;
+    }
+
+    int current_route_id() const {
+      return current_route_id_;
+    }
+
+    int64 current_frame_id() const {
+      return current_webkit_frame_.frame_id;
+    }
+
+    bool is_top_level() const {
+      return is_top_level_;
+    }
+
+    void UpdateFrame(int new_process_host_id,
+                     int new_route_id,
+                     int64 new_frame_id);
+
+    // TODO(supersat): Not currently used.
+    BrowsingInstanceFrame* FindById(int64 id);
+
+  private:
+    int64 id_;
+
+    BrowsingInstanceFrame* parent_;
+    std::list<BrowsingInstanceFrame*> children_;

[Charlie Reis, 2011/12/01 23:13:02]

Parent and child frames usually refer to the frame tree in a particular tab.  Do
you mean the opener and opened frames?

[supersat, 2011/12/09 23:08:20]

I'm actually not sure what I intended these to be used for. They're not used
right now, so I'll just take them out.

+
+    WebKitFrameIdTuple current_webkit_frame_;
+    int current_route_id_;
+    bool is_top_level_;
+};
+
+}  // namespace content
+
+#if defined(COMPILER_GCC)
+namespace __gnu_cxx {
+
+template<>
+struct hash<content::BrowsingInstanceFrame::WebKitFrameIdTuple> {
+  std::size_t operator()(const
+      content::BrowsingInstanceFrame::WebKitFrameIdTuple& p) const {
+    return p.process_host_id * 65537 + p.process_host_id * 257 + p.frame_id;
+  }
+};
+
+}  // namespace __gnu_cxx
+#endif
+
+#endif  // CONTENT_BROWSER_WORKER_HOST_BROWSING_INSTANCE_FRAME_ID_H_