Cross-process postMessage

chrome/common/chrome_content_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_content_client.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
@@ skipping 281 matching lines @@
   mimeType.mime_type = "*";
   info.mime_types.push_back(mimeType);
 
   webkit::npapi::PluginList::Singleton()->RegisterInternalPlugin(
       info,
       entry_points,
       false);
 #endif
 }
 
-bool ChromeContentClient::CanSendWhileSwappedOut(const IPC::Message* msg) {
-  // Any Chrome-specific messages that must be allowed to be sent from swapped
-  // out renderers.
-  switch (msg->type()) {
-    case ChromeViewHostMsg_DomOperationResponse::ID:
-      return true;
-    default:
-      break;
-  }
-  return false;
-}
-
 bool ChromeContentClient::CanHandleWhileSwappedOut(
     const IPC::Message& msg) {
-  // Any Chrome-specific messages (apart from those listed in
-  // CanSendWhileSwappedOut) that must be handled by the browser when sent from
-  // swapped out renderers.
+  // Any Chrome-specific messages that must be handled by the browser when sent
+  // from swapped out renderers.
   switch (msg.type()) {
+    case ChromeViewHostMsg_DomOperationResponse::ID:

[Charlie Reis, 2011/12/01 23:13:02]

Is this a worthwhile change independent of the rest of the code, or is it only
needed when we change about:swappedout?  Just wondering if we should land it in
its own CL.

[supersat, 2011/12/09 23:08:20]

It's only needed if we change about:swappedout.

[Charlie Reis, 2011/12/12 22:20:36]

Ok.  It's still there in patch set 2, so you should probably remove it.

[supersat, 2011/12/15 19:30:49]

Done. Not sure why it wasn't in patch set 2.

     case ChromeViewHostMsg_Snapshot::ID:
       return true;
     default:
       break;
   }
   return false;
 }
 
 std::string ChromeContentClient::GetUserAgent(bool* overriding) const {
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kUserAgent)) {
@@ skipping 79 matching lines @@
   DCHECK(sandbox_profile_resource_id);
   if (sandbox_type == CHROME_SANDBOX_TYPE_NACL_LOADER) {
     *sandbox_profile_resource_id = IDR_NACL_SANDBOX_PROFILE;
     return true;
   }
   return false;
 }
 #endif
 
 }  // namespace chrome