Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 8760021: Print Preview: Added "Fit to page" string. (Closed)

Created:
9 years ago by kmadhusu
Modified:
9 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Print Preview: Added "Fit to page" string. BUG=85132 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112505

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kmadhusu
9 years ago (2011-12-01 02:28:17 UTC) #1
Lei Zhang
LGTM Isn't there a BUG= number you can set for this? http://codereview.chromium.org/8760021/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): ...
9 years ago (2011-12-01 08:35:24 UTC) #2
kmadhusu
http://codereview.chromium.org/8760021/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/8760021/diff/1/chrome/app/generated_resources.grd#newcode6491 chrome/app/generated_resources.grd:6491: <message name="IDS_PRINT_PREVIEW_OPTION_FIT_TO_PAGE" desc="Checkbox label that provides a choice to ...
9 years ago (2011-12-01 17:56:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/8760021/3002
9 years ago (2011-12-01 17:56:55 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-01 20:03:23 UTC) #5
Change committed as 112505

Powered by Google App Engine
This is Rietveld 408576698