Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 8760018: Trigger didCommitAndDrawCompositorFrame on Swapbuffers complete (Closed)

Created:
9 years ago by jbauman
Modified:
9 years ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Trigger didCommitAndDrawCompositorFrame on fullscreen Swapbuffers The compositor isn't really running in this case, so we have to run the callback here to make sure the next frame is created. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112417

Patch Set 1 #

Patch Set 2 : call on swapbuffers #

Total comments: 1

Patch Set 3 : remove if check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbauman
9 years ago (2011-12-01 00:58:43 UTC) #1
piman
Why not do it in SwapBuffers()? The "compositor" rate limit will still kick in, and ...
9 years ago (2011-12-01 01:13:10 UTC) #2
jbauman
On 2011/12/01 01:13:10, piman wrote: > Why not do it in SwapBuffers()? The "compositor" rate ...
9 years ago (2011-12-01 04:59:08 UTC) #3
piman
lgtm http://codereview.chromium.org/8760018/diff/3001/content/renderer/render_widget_fullscreen_pepper.cc File content/renderer/render_widget_fullscreen_pepper.cc (right): http://codereview.chromium.org/8760018/diff/3001/content/renderer/render_widget_fullscreen_pepper.cc#newcode492 content/renderer/render_widget_fullscreen_pepper.cc:492: if (is_accelerated_compositing_active_) No need for the if. It ...
9 years ago (2011-12-01 05:04:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/8760018/6001
9 years ago (2011-12-01 05:14:35 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-01 06:51:43 UTC) #6
Change committed as 112417

Powered by Google App Engine
This is Rietveld 408576698