Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 8760016: Hide private IDL files from generator behind "--include_private" flag (Closed)

Created:
9 years ago by jvoung - send to chromium...
Modified:
9 years ago
Reviewers:
noelallen1, piman
CC:
chromium-reviews
Visibility:
Public.

Description

Hide private IDL files from generator behind "--include_private" flag until all the private IDL files can generate the correct .h files. BUG= none TEST= ./generator.py && ./generator.py --wnone --cgen --range=start,end --include_private --out private/ppb_flash_fullscreen.idl R=noelallen@chromium.org,piman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ppapi/generators/idl_parser.py View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jvoung - send to chromium...
9 years ago (2011-11-30 23:41:52 UTC) #1
piman
lgtm
9 years ago (2011-11-30 23:54:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@google.com/8760016/1
9 years ago (2011-12-01 00:06:12 UTC) #3
noelallen1
LGTM nit: I think the reverse is safer (--exclude-private) or just use api/*.idl api/dev/*.idl, etc... ...
9 years ago (2011-12-01 00:25:42 UTC) #4
noelallen1
BTW, I'm assuming this is temporary and that we can switch it to the other ...
9 years ago (2011-12-01 00:26:42 UTC) #5
jvoung - send to chromium...
On 2011/12/01 00:26:42, noelallen1 wrote: > BTW, I'm assuming this is temporary and that we ...
9 years ago (2011-12-01 00:30:46 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-01 01:58:19 UTC) #7
Change committed as 112373

Powered by Google App Engine
This is Rietveld 408576698