Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 8760012: Move view_types.h to view_type.h, since that's the standard name for enums. (Closed)

Created:
9 years ago by jam
Modified:
9 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, creis+watch_chromium.org, kkania, yoshiki+watch_chromium.org, Erik does not do reviews, ajwong+watch_chromium.org, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, robertshield
Visibility:
Public.

Description

Move view_types.h to view_type.h, since that's the standard name for enums. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112365

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -112 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webkit_preferences.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/network_delay_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/network_delay_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/common/chrome_view_type.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/common/chrome_view_type.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/chrome_view_types.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/common/chrome_view_types.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/schema_generated_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_input_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/common/view_type.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
D content/public/common/view_types.h View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years ago (2011-11-30 23:27:03 UTC) #1
Avi (use Gerrit)
9 years ago (2011-11-30 23:30:40 UTC) #2
rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698