Issue 8760010: Ensure HttpResponseHeaders::raw_headers_ always ends with 2 '\0' characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8760010: Ensure HttpResponseHeaders::raw_headers_ always ends with 2 '\0' characters. (Closed)

Created:
9 years ago by Matt Perry

Modified:
9 years ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, battre

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ensure HttpResponseHeaders::raw_headers_ always ends with 2 '\0' characters. BUG=105971 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112401

Patch Set 3 : fixed tests #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -5 lines)			Patch
	M	net/http/http_response_headers.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/http/http_response_headers.cc	View	1 2	5 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

lgtm http://codereview.chromium.org/8760010/diff/1/net/http/http_response_headers.cc File net/http/http_response_headers.cc (right): http://codereview.chromium.org/8760010/diff/1/net/http/http_response_headers.cc#newcode393 net/http/http_response_headers.cc:393: raw_headers_.push_back('\0'); // terminate status line with a null ...

9 years ago (2011-11-30 22:53:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/8760010/6001

9 years ago (2011-12-01 02:44:44 UTC) #4

Change committed as 112401

Expand Messages | Collapse Messages

Issue 8760010: Ensure HttpResponseHeaders::raw_headers_ always ends with 2 '\0' characters. (Closed)

Description

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : fixed tests #

Messages