Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8760008: Cleanup: Remove some cruft from RenderViewHostDelegate. (Closed)

Created:
9 years ago by Lei Zhang
Modified:
9 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Cleanup: Remove some cruft from RenderViewHostDelegate. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112600

Patch Set 1 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M chrome/browser/tab_contents/tab_contents_ssl_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 3 chunks +4 lines, -5 lines 2 comments Download
M content/browser/renderer_host/render_view_host_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
http://codereview.chromium.org/8760008/diff/4001/content/browser/renderer_host/render_view_host_delegate.h File content/browser/renderer_host/render_view_host_delegate.h (left): http://codereview.chromium.org/8760008/diff/4001/content/browser/renderer_host/render_view_host_delegate.h#oldcode83 content/browser/renderer_host/render_view_host_delegate.h:83: // NOTE: this takes ownership of @modal_dialog_event Apparently this ...
9 years ago (2011-12-01 18:06:56 UTC) #1
Avi (use Gerrit)
LGTM http://codereview.chromium.org/8760008/diff/4001/content/browser/renderer_host/render_view_host_delegate.h File content/browser/renderer_host/render_view_host_delegate.h (left): http://codereview.chromium.org/8760008/diff/4001/content/browser/renderer_host/render_view_host_delegate.h#oldcode83 content/browser/renderer_host/render_view_host_delegate.h:83: // NOTE: this takes ownership of @modal_dialog_event On ...
9 years ago (2011-12-01 20:10:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8760008/4001
9 years ago (2011-12-01 20:15:48 UTC) #3
commit-bot: I haz the power
Try job failure for 8760008-4001 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=3107 Step "update" is always ...
9 years ago (2011-12-01 20:19:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8760008/4001
9 years ago (2011-12-01 22:13:11 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-02 02:18:03 UTC) #6 
Change committed as 112600

Powered by Google App Engine
This is Rietveld 408576698