Issue 8760003: [ntp4] Remove bookmarks page implementation and resources.

Issue 8760003: [ntp4] Remove bookmarks page implementation and resources. (Closed)

Created:
9 years ago by csilv

Modified:
9 years ago

Reviewers:
Dan Beam, Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[ntp4] Remove bookmarks page implementation and resources. BUG=105941 TEST=Verify NTP4 page continues to function properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112525

Patch Set 1 #

Patch Set 2 : add missing file #

Patch Set 3 : update page_list_view.js #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1431 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/browser/resources/ntp4/bookmarks_page.css	View		1 chunk	+0 lines, -178 lines	0 comments	Download
D	chrome/browser/resources/ntp4/bookmarks_page.js	View		1 chunk	+0 lines, -652 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View		3 chunks	+0 lines, -35 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.js	View		4 chunks	+0 lines, -62 lines	0 comments	Download
M	chrome/browser/resources/ntp4/page_list_view.js	View	1 2	6 chunks	+4 lines, -29 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/bookmarks_handler.h	View		1 chunk	+0 lines, -94 lines	0 comments	Download
D	chrome/browser/ui/webui/ntp/bookmarks_handler.cc	View		1 chunk	+0 lines, -338 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.cc	View		5 chunks	+1 line, -12 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csilv

+estade, +dbeam for review Note: I didn't perform a string audit for this CL. Evan's ...

9 years ago (2011-11-30 22:02:04 UTC) #1

Dan Beam

Please remove all the bookmarks related logic in page_list_view.js as well.

9 years ago (2011-11-30 23:04:55 UTC) #3

csilv

On 2011/11/30 23:04:55, Dan Beam wrote: > Please remove all the bookmarks related logic in ...

9 years ago (2011-11-30 23:31:26 UTC) #4

lgtm

Expand Messages | Collapse Messages