Be more careful when calling methods on chromeHidden

Be more careful when calling methods on chromeHidden. If chromeHidden didn't have the method before, it would stop the current stack because of an unhandled try/catch.

BUG=100401
TEST=described in bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112521

[Aaron Boodman, 2011-12-01 05:58:31]

http://codereview.chromium.org/8759018/diff/2001/chrome/renderer/extensions/c...
File chrome/renderer/extensions/chrome_v8_context.cc (right):

http://codereview.chromium.org/8759018/diff/2001/chrome/renderer/extensions/c...
chrome/renderer/extensions/chrome_v8_context.cc:56: if (!value.IsEmpty() &&
value->IsObject()) {
FYI: This is the part that actually fixes the bug, the other stuff is just extra
defense.

[Matt Perry, 2011-12-01 18:57:29]

LGTM

http://codereview.chromium.org/8759018/diff/2001/chrome/renderer/extensions/c...
File chrome/renderer/extensions/chrome_v8_context.cc (right):

http://codereview.chromium.org/8759018/diff/2001/chrome/renderer/extensions/c...
chrome/renderer/extensions/chrome_v8_context.cc:47: v8::TryCatch try_catch;
Meh, this seems like overkill given that:
- we now only cast to X after testing that value->IsX
- v8 will crash anyway if we don't catch here

[commit-bot: I haz the power, 2011-12-01 19:37:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/8759018/2001

[commit-bot: I haz the power, 2011-12-01 19:44:35]

Try job failure for 8759018-2001 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.