Issue 8759013: Dispatch the Windows font caching IPCs in one filter. This avoids having the code that calls thos...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8759013: Dispatch the Windows font caching IPCs in one filter. This avoids having the code that calls thos... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
arthurhsu

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Dispatch the Windows font caching IPCs in one filter. This avoids having the code that calls those functions be duplicated and also makes the chrome service code not know about internal content IPCs. It also cleans up ChildProcessHost a bit, which will be useful when it gets an interface around it for the Content API. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112492

Patch Set 1 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+244 lines, -268 lines)			Patch
M	chrome/service/service_utility_process_host.h	View	3 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/service/service_utility_process_host.cc	View	5 chunks	+5 lines, -23 lines	0 comments	Download
M	content/browser/ppapi_plugin_process_host.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	content/browser/ppapi_plugin_process_host.cc	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	content/browser/renderer_host/render_message_filter.h	View	3 chunks	+1 line, -14 lines	0 comments	Download
M	content/browser/renderer_host/render_message_filter.cc	View	3 chunks	+1 line, -25 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/common/child_process_host.h	View	3 chunks	+0 lines, -41 lines	0 comments	Download
M	content/common/child_process_host.cc	View	3 chunks	+5 lines, -134 lines	0 comments	Download
A	content/common/font_cache_dispatcher_win.h	View	1 chunk	+42 lines, -0 lines	0 comments	Download
A	content/common/font_cache_dispatcher_win.cc	View	1 chunk	+185 lines, -0 lines	0 comments	Download
M	content/content_common.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2011/12/01 02:29:11, John Abd-El-Malek wrote:

LGTM

Expand Messages | Collapse Messages