Add "Instant:" prefix to Instant preview tabs in the Task manager.

Add "Instant:" prefix to Instant preview tabs in the Task manager.

BUG=105130
TEST=Open Task Manager. Enable Instant. Type a query into the omnibox. Observe that the Instant preview is listed as "Instant: ..." instead of "Tab: ...".


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112745

[sreeram, 2011-12-01 01:31:00]

@dominich for review and @sky/@yoshiki for approval.

[sky, 2011-12-01 01:48:56]

http://codereview.chromium.org/8759009/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager_resource_providers.cc (right):

http://codereview.chromium.org/8759009/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_resource_providers.cc:73: int
GetMessagePrefixID(bool is_app, bool is_extension, bool is_incognito,
nit: when you wrap each param on its own line.

http://codereview.chromium.org/8759009/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_resource_providers.cc:241: for
(BrowserList::const_iterator i = BrowserList::begin();
How often is this called? Should it be cached?

[dominich, 2011-12-01 15:33:04]

lgtm

[sreeram, 2011-12-01 20:35:25]

http://codereview.chromium.org/8759009/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager_resource_providers.cc (right):

http://codereview.chromium.org/8759009/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_resource_providers.cc:73: int
GetMessagePrefixID(bool is_app, bool is_extension, bool is_incognito,
On 2011/12/01 01:48:56, sky wrote:
> nit: when you wrap each param on its own line.

Done.

http://codereview.chromium.org/8759009/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager_resource_providers.cc:241: for
(BrowserList::const_iterator i = BrowserList::begin();
On 2011/12/01 01:48:56, sky wrote:
> How often is this called? Should it be cached?

Done.

[sky, 2011-12-01 20:39:11]

LGTM

[commit-bot: I haz the power, 2011-12-01 23:17:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sreeram@chromium.org/8759009/4002

[commit-bot: I haz the power, 2011-12-02 02:32:31]

Try job failure for 8759009-4002 (retry) (previous was lost) (retry) on win_rel
for step "update".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-12-02 17:37:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sreeram@chromium.org/8759009/4002

[commit-bot: I haz the power, 2011-12-02 18:53:56]

Change committed as 112745