Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 8759005: Mark test mjsunit/debug-step-2 as failing (Closed)

Created:
9 years ago by Søren Gjesse
Modified:
9 years ago
Reviewers:
Rico, danno
CC:
v8-dev
Visibility:
Public.

Description

Mark test mjsunit/debug-step-2 as failing This is due to the revert of precise stepping enhancement on this 3.6 branch. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=10119

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/version.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
I did not bump the version number for this change.
9 years ago (2011-11-30 23:06:23 UTC) #1
Rico
LGTM
9 years ago (2011-12-01 07:32:34 UTC) #2
Rico
On 2011/12/01 07:32:34, Rico wrote: > LGTM Actually, you should up the version number in ...
9 years ago (2011-12-01 07:49:44 UTC) #3
Rico
On 2011/12/01 07:49:44, Rico wrote: > On 2011/12/01 07:32:34, Rico wrote: > > LGTM > ...
9 years ago (2011-12-01 07:50:21 UTC) #4
Søren Gjesse
9 years ago (2011-12-01 07:58:07 UTC) #5
On 2011/12/01 07:50:21, Rico wrote:
> On 2011/12/01 07:49:44, Rico wrote:
> > On 2011/12/01 07:32:34, Rico wrote:
> > > LGTM
> > 
> > Actually, you should up the version number in version.cc
> An your message clearly states that you don't wan't to

I will bump the version number then.

Powered by Google App Engine
This is Rietveld 408576698