Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5613)

Unified Diff: chrome/test/functional/process_count.py

Issue 8759003: Fix testProcessCountCombination on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/process_count.py
diff --git a/chrome/test/functional/process_count.py b/chrome/test/functional/process_count.py
index 32ebf741c63092fc348708c45445d2285a0b5be6..f74e9f5015138cf42e9772c64fc6f4b6a7bf5e5a 100755
--- a/chrome/test/functional/process_count.py
+++ b/chrome/test/functional/process_count.py
@@ -64,16 +64,17 @@ class ProcessCountTest(pyauto.PyUITest):
browser_info = [x for x in proc_info['browsers']
if x['process_name'] == self.chrome_proc_name]
assert len(browser_info) == 1
- # Utility processes may show up any time. Ignore them.
+ # Utility & GPU processes may show up any time. Ignore them.
processes = [x for x in browser_info[0]['processes']
- if x['child_process_type'] != 'Utility']
+ if x['child_process_type'] not in ('Utility', 'GPU')]
num_actual = len(processes)
self.assertEqual(num_actual, num_expected,
- msg='Number of processes (ignoring Utility processes) '
+ msg='Number of processes (ignoring Utility/GPU processes) '
'should be %d, but was %d.\n'
- 'Actual process info:\n%s' % (
- num_expected, num_actual, self.pformat(proc_info)))
+ 'Actual processes:\n%s' % (
+ num_expected, num_actual,
+ [x['child_process_type'] for x in processes]))
def testProcessCountFreshProfile(self):
"""Verifies the process count in a fresh profile."""
@@ -93,11 +94,7 @@ class ProcessCountTest(pyauto.PyUITest):
"""Verifies the process count when the flash process is running."""
flash_url = self.GetFileURLForDataPath('plugin', 'flash.swf')
self.NavigateToURL(flash_url)
- if self.IsChromeOS():
- # Flash triggers an extra GPU process on ChromeOS.
- self._VerifyProcessCount(self.proc_count_fresh_profile + 2)
- else:
- self._VerifyProcessCount(self.proc_count_fresh_profile + 1)
+ self._VerifyProcessCount(self.proc_count_fresh_profile + 1)
def testProcessCountExtensionProcess(self):
"""Verifies the process count when an extension is installed."""
@@ -134,11 +131,7 @@ class ProcessCountTest(pyauto.PyUITest):
for _ in xrange(3):
self.AppendTab(pyauto.GURL('about:blank'), 1)
- if self.IsChromeOS():
- # Flash triggers an extra GPU process on ChromeOS.
- self._VerifyProcessCount(self.proc_count_fresh_profile + 9)
- else:
- self._VerifyProcessCount(self.proc_count_fresh_profile + 8)
+ self._VerifyProcessCount(self.proc_count_fresh_profile + 8)
if __name__ == '__main__':
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698