Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 8758007: Check $? of 'make' before a 'set -e' call. Else it is overridden. (Closed)

Created:
9 years ago by John Grabowski
Modified:
9 years ago
Reviewers:
michaelbai
CC:
chromium-reviews
Visibility:
Public.

Description

Check $? of 'make' before a 'set -e' call. Else it is overridden. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/buildbot.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
John Grabowski
9 years ago (2011-11-30 22:55:21 UTC) #1
michaelbai
9 years ago (2011-11-30 22:56:06 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698