|
Revert 112178 - [Sync] Make syncer commands avoid posting tasks on threads with no work to do
Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand.
Use that to figure out which worker threads to post work on (instead of
posting on all of them).
Implement GetGroupsToChange() for each ModelChangingSyncerCommand.
Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession.
Key unapplied updates index by type for ApplyUpdatesCommand.
Make the abstract methods of ModelChangingSyncerCommand protected.
BUG= 97832
TEST=
Review URL: http://codereview.chromium.org/8637006
TBR=akalin@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112318
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+104 lines, -807 lines) |
Patch |
 |
M |
chrome/browser/sync/engine/apply_updates_command.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/apply_updates_command.cc
|
View
|
|
3 chunks |
+8 lines, -48 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/apply_updates_command_unittest.cc
|
View
|
|
12 chunks |
+2 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/build_and_process_conflict_sets_command.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/engine/build_and_process_conflict_sets_command_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -52 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/model_changing_syncer_command.h
|
View
|
|
2 chunks |
+0 lines, -17 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/model_changing_syncer_command.cc
|
View
|
|
2 chunks |
+19 lines, -4 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/engine/model_changing_syncer_command_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -74 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/process_commit_response_command.h
|
View
|
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/process_commit_response_command.cc
|
View
|
|
2 chunks |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/process_commit_response_command_unittest.cc
|
View
|
|
4 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/process_updates_command.h
|
View
|
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/process_updates_command.cc
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/engine/process_updates_command_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -52 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/resolve_conflicts_command.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/resolve_conflicts_command.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/sync/engine/resolve_conflicts_command_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -51 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/sync_scheduler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/syncer_unittest.cc
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/update_applicator.cc
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/verify_updates_command.h
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/verify_updates_command.cc
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/engine/verify_updates_command_unittest.cc
|
View
|
|
3 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/sessions/status_controller.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/sessions/status_controller.cc
|
View
|
|
2 chunks |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/sessions/sync_session.h
|
View
|
|
5 chunks |
+2 lines, -16 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/sessions/sync_session.cc
|
View
|
|
5 chunks |
+5 lines, -87 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/sessions/sync_session_unittest.cc
|
View
|
|
12 chunks |
+13 lines, -129 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/syncable/syncable.h
|
View
|
|
4 chunks |
+5 lines, -13 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/syncable/syncable.cc
|
View
|
|
13 chunks |
+32 lines, -84 lines |
0 comments
|
Download
|
 |
MM |
chrome/browser/sync/syncable/syncable_unittest.cc
|
View
|
|
7 chunks |
+8 lines, -9 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test/engine/fake_model_safe_worker_registrar.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test/engine/syncer_command_test.h
|
View
|
|
3 chunks |
+0 lines, -41 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests.gypi
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
Total messages: 1 (0 generated)
|