Issue 8758003: Remove dead code for gpu blacklist auto-update.

Issue 8758003: Remove dead code for gpu blacklist auto-update. (Closed)

Created:
9 years ago by Zhenyao Mo

Modified:
9 years ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove dead code for gpu blacklist auto-update. BUG=103851 TEST=tree R=kbr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112879

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -234 lines)			Patch
M	chrome/browser/browser_process.h	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_process_impl.h	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	1	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View	1	4 chunks	+26 lines, -3 lines	0 comments	Download
D	chrome/browser/web_resource/gpu_blacklist_updater.h	View		1 chunk	+0 lines, -34 lines	0 comments	Download
D	chrome/browser/web_resource/gpu_blacklist_updater.cc	View		1 chunk	+0 lines, -120 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/test/base/testing_browser_process.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/base/testing_browser_process.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/test/gpu/gpu_feature_browsertest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/gpu/gpu_data_manager.h	View	1	1 chunk	+1 line, -7 lines	0 comments	Download
M	content/browser/gpu/gpu_data_manager.cc	View	1	1 chunk	+3 lines, -38 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

LGTM. One comment to think about. http://codereview.chromium.org/8758003/diff/12007/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): http://codereview.chromium.org/8758003/diff/12007/chrome/browser/chrome_browser_main.cc#newcode438 chrome/browser/chrome_browser_main.cc:438: void InitializeGpuDataManager(const CommandLine& ...

9 years ago (2011-12-03 02:39:15 UTC) #2

Zhenyao Mo

9 years ago (2011-12-03 07:16:22 UTC) #3

On 2011/12/03 02:39:15, kbr wrote:
> LGTM. One comment to think about.
> 
>
http://codereview.chromium.org/8758003/diff/12007/chrome/browser/chrome_brows...
> File chrome/browser/chrome_browser_main.cc (right):
> 
>
http://codereview.chromium.org/8758003/diff/12007/chrome/browser/chrome_brows...
> chrome/browser/chrome_browser_main.cc:438: void InitializeGpuDataManager(const
> CommandLine& parsed_command_line) {
> It seems to me that most of this logic would be better encapsulated as a
method
> on GpuDataManager now.

Yes, I totally agree.  It's been my plan to move GpuDataManager and GpuBlacklist
from content to chrome side, so we could encapsulate it properly.

Expand Messages | Collapse Messages